Remove all `i` suffixes by tbu- · Pull Request #21631 · rust-lang/rust

tbu- · 2015-01-25T21:08:09Z

They are either constrained to isize anyway or correctly fall back to i32.

rust-highfive · 2015-01-25T21:08:16Z

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-01-26T08:39:52Z

@bors: r+ 82b0b02

bors · 2015-01-27T05:15:03Z

☔ Merge conflict

tbu- · 2015-01-27T20:13:44Z

@alexcrichton Rebased.

alexcrichton · 2015-01-27T20:17:29Z

@bors: r+ 4067be8

bors · 2015-01-27T20:17:29Z

🙀 You have the wrong number! Please try again with 4067b8e.

alexcrichton · 2015-01-27T20:17:43Z

@bors: r+ 4067b8e

bors · 2015-01-28T14:42:28Z

☔ Merge conflict

tbu- · 2015-01-28T17:27:58Z

@alexcrichton Rebased.

alexcrichton · 2015-01-28T17:28:54Z

@bors: r+ 876fafe

bors · 2015-01-28T18:04:20Z

⌛ Testing commit 876fafe with merge c32614c...

bors · 2015-01-28T18:55:23Z

💔 Test failed - auto-mac-64-opt

tbu- · 2015-01-28T20:17:15Z

@alexcrichton Fixed test failure, ran make check again.

alexcrichton · 2015-01-28T20:19:48Z

@bors: r+ f0597ea

frewsxcv · 2015-01-28T22:01:01Z

Needs a rebase

tbu- · 2015-01-28T22:37:37Z

@alexcrichton Rebased.

alexcrichton · 2015-01-28T22:42:20Z

@bors: r+ 8440329

sorry for all the rebases :(

bors · 2015-01-28T22:42:23Z

🙀 You have the wrong number! Please try again with f0597ea.

alexcrichton · 2015-01-29T00:32:16Z

@bors: r+ 8440329

bors · 2015-01-29T00:32:17Z

🙀 You have the wrong number! Please try again with f0597ea.

alexcrichton · 2015-01-29T00:34:22Z

@bors: r+ 8440329

bors · 2015-01-29T02:58:49Z

⌛ Testing commit 8440329 with merge f5f6ea6...

bors · 2015-01-29T04:05:50Z

💔 Test failed - auto-mac-64-opt

tbu- · 2015-01-30T01:50:37Z

@alexcrichton Sorry, I ran make check locally, does that run all tests?

alexcrichton · 2015-01-30T02:35:20Z

It should yeah, perhaps it was just a merge conflict between r+ and when it was tested?

Gankra · 2015-01-30T03:05:17Z

Github seems to think it's a merge conflict. I sugges we p=1 this change when it's next ready.

tbu- · 2015-01-30T03:39:53Z

@alexcrichton Rebased. Ran make check.

Gankra · 2015-01-30T03:48:46Z

@bors r+ 7f64 p=1

tbu- · 2015-01-30T03:52:45Z

@gankro It looks like you need a colon after the @bors.

Gankra · 2015-01-30T03:55:47Z

@tbu- No if you checkout http://buildbot.rust-lang.org/homu/queue/rust your PR is there.

You know you did it right if bors doesn't complain.

e.g.

@bors r+ asdas

Should have it scream instantly.

bors · 2015-01-30T03:55:48Z

🙀 You have the wrong number! Please try again with 7f64fe4.

bors · 2015-01-30T04:09:26Z

⌛ Testing commit 7f64fe4 with merge 5ada928...

bors · 2015-01-30T05:05:11Z

💔 Test failed - auto-mac-64-opt

Gankra · 2015-01-30T14:30:57Z

Looks like there's some conflicts in old_io

alexcrichton · 2015-01-30T20:15:16Z

Merging this into a rollup I'm making (no need to rebase)

Conflicts: src/libcoretest/iter.rs

…ing-cycles internal: Refactor handling of associated type shorthand for type parameters, i.e. `T::AssocType` without specifying the trait

rust-highfive assigned pcwalton Jan 25, 2015

alexcrichton assigned alexcrichton and unassigned pcwalton Jan 26, 2015

tbu- force-pushed the isize_police branch from 82b0b02 to 4067b8e Compare January 27, 2015 19:38

tbu- force-pushed the isize_police branch from 4067b8e to 876fafe Compare January 28, 2015 17:27

tbu- force-pushed the isize_police branch from 876fafe to f0597ea Compare January 28, 2015 20:17

tbu- force-pushed the isize_police branch from f0597ea to 8440329 Compare January 28, 2015 22:37

Remove all i suffixes

7f64fe4

tbu- force-pushed the isize_police branch from 8440329 to 7f64fe4 Compare January 30, 2015 03:39

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 30, 2015

rollup merge of rust-lang#21631: tbu-/isize_police

188d7c0

Conflicts: src/libcoretest/iter.rs

alexcrichton merged commit 7f64fe4 into rust-lang:master Jan 31, 2015

Uh oh!

Comments

Conversation

tbu- commented Jan 25, 2015

Uh oh!

rust-highfive commented Jan 25, 2015

Uh oh!

alexcrichton commented Jan 26, 2015

Uh oh!

bors commented Jan 27, 2015

Uh oh!

tbu- commented Jan 27, 2015

Uh oh!

alexcrichton commented Jan 27, 2015

Uh oh!

bors commented Jan 27, 2015

Uh oh!

alexcrichton commented Jan 27, 2015

Uh oh!

bors commented Jan 28, 2015

Uh oh!

tbu- commented Jan 28, 2015

Uh oh!

alexcrichton commented Jan 28, 2015

Uh oh!

bors commented Jan 28, 2015

Uh oh!

bors commented Jan 28, 2015

Uh oh!

tbu- commented Jan 28, 2015

Uh oh!

alexcrichton commented Jan 28, 2015

Uh oh!

frewsxcv commented Jan 28, 2015

Uh oh!

tbu- commented Jan 28, 2015

Uh oh!

alexcrichton commented Jan 28, 2015

Uh oh!

bors commented Jan 28, 2015

Uh oh!

alexcrichton commented Jan 29, 2015

Uh oh!

bors commented Jan 29, 2015

Uh oh!

alexcrichton commented Jan 29, 2015

Uh oh!

bors commented Jan 29, 2015

Uh oh!

bors commented Jan 29, 2015

Uh oh!

tbu- commented Jan 30, 2015

Uh oh!

alexcrichton commented Jan 30, 2015

Uh oh!

Gankra commented Jan 30, 2015

Uh oh!

tbu- commented Jan 30, 2015

Uh oh!

Gankra commented Jan 30, 2015

Uh oh!

tbu- commented Jan 30, 2015

Uh oh!

Gankra commented Jan 30, 2015

Uh oh!

bors commented Jan 30, 2015

Uh oh!

bors commented Jan 30, 2015

Uh oh!

bors commented Jan 30, 2015

Uh oh!

Gankra commented Jan 30, 2015

Uh oh!

alexcrichton commented Jan 30, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone