rustdoc: Stop adding #[deny(warnings)] to all tests #20786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we are warning about unstable APIs and there are many of these yet, this creates a high likelyhood doc tests will fail. This doesn't seem right as a blanket policy to me anyway, though certainly we want it in std. Probably more appropriate to add a rustdoc option.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Jan 9, 2015
Because we are warning about unstable APIs and there are many of these yet, this creates a high likelyhood doc tests will fail. This doesn't seem right as a blanket policy to me anyway, though certainly we want it in std. Probably more appropriate to add a rustdoc option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are warning about unstable APIs and there are many
of these yet, this creates a high likelyhood doc tests will
fail.
This doesn't seem right as a blanket policy to me anyway, though
certainly we want it in std. Probably more appropriate to add
a rustdoc option.