Small macro cleanups #20776
Merged
Small macro cleanups #20776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| panic!(concat!("assertion failed: ", stringify!($cond))) | ||
| } | ||
| ); | ||
| ($cond:expr, $($arg:tt)+) => ( |
There was a problem hiding this comment.
this use of :tt wasn't actually propagated down to libcore, could you do that as well?
|
Nice thinking! I forgot we could rely on Could you basically do a pass where you copy-paste the current definitions into libcore? They've been tweaked slightly and just want to make sure all the changes stay in place. Thanks! |
added 2 commits
January 9, 2015 11:06
The libstd definitions move to libcore, which causes some minor updates there.
kmcallister
force-pushed
the
macro-cleanup
branch
from
7c8f120 to
a96a8b2
Compare
|
Pushed the libcore updates, along with a rebase.
Yeah, this basically exploits a lack of hygiene on macros referring to other macros. Which I don't think we'll fix any time soon... |
bors
added a commit
that referenced
this pull request
Jan 9, 2015
r? @alexcrichton. This passes tests for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton. This passes tests for me.