Skip to content

Fix unboxed closure ICE #20527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2015
Merged

Conversation

nikomatsakis
Copy link
Contributor

This fixes an ICE that japaric was encountering in the wf checker.

r? @aturon

@japaric
Copy link
Member

japaric commented Jan 4, 2015

This is blocking the removal of boxed closures. This needs to get in a snapshot to be able to remove them.

@nikomatsakis
Copy link
Contributor Author

(Please give high priority.)

@japaric
Copy link
Member

japaric commented Jan 4, 2015

(@aturon you r+ed on the rust-lang repo instead of @nikomatsakis's fork, I put the r+ on the right place)

@aturon
Copy link
Member

aturon commented Jan 4, 2015

@japaric This seems to be a github inconsistency, right? I don't think I'm varying the way I reach these commits...

bors added a commit that referenced this pull request Jan 4, 2015
…aturon

This fixes an ICE that japaric was encountering in the wf checker.

r? @aturon
@nikomatsakis
Copy link
Contributor Author

@aturon yes you have to check the URL bar to see if it says "rust-lang" or "nikomatsakis" -- as far as I know, it's random.

@japaric
Copy link
Member

japaric commented Jan 4, 2015

This seems to be a github inconsistency, right? I don't think I'm varying the way I reach these commits...

Yes, I think so. It has also happened to me. Best to double check from now on...

@alexcrichton
Copy link
Member

I've found that if you click a commit just after it was uploaded, you'll go to the rust-lang commit, but if you wait a bit it'll take you to the $user commit.

yay github!

@bors bors merged commit 537139e into rust-lang:master Jan 4, 2015
@nikomatsakis nikomatsakis deleted the japaric-boxed-uc-ice-fix branch March 30, 2016 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants