Fix a handful of ICEs around casting #17646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
err, removing r+ actually, it's a good point of whether we want the enum -> pointer coercions. |
|
cc @pcwalton, when enum discriminants change to all |
|
I'm happy to fix typeck if it's determined that enum to pointer casts should not be allowed. |
|
typeck disallows casting directly from enum to float and tells the user to cast through an integer type, so it seems like doing the same for pointers is the most reasonable approach. I'll rework the patch stack a bit to do this. |
…pressions Closes issue rust-lang#17458
|
Oh oops, I failed to notice that the patch now disallows that sort of cast! This looks good to me, thanks @bkoropoff! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 2, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
Add missing dyn parse special cases in 2015 edition There were a few more special cases to consider here -> rust-lang/reference#1538
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
Add missing dyn parse special cases in 2015 edition There were a few more special cases to consider here -> rust-lang/reference#1538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes missing cases in trans for various casts that are permitted by typeck. I wasn't sure whether some of these were actually intended to be allowed (e.g. enum -> pointer), so each commit is a self-contained change that can easily be dropped if necessary.
Closes issue #17458
Closes issue #17444