Skip to content

even more cleanups for rustc_builtin_macros - #162925

Open
cyrgani wants to merge 10 commits into
rust-lang:mainfrom
cyrgani:builtin-macros-4
Open

even more cleanups for rustc_builtin_macros#162925
cyrgani wants to merge 10 commits into
rust-lang:mainfrom
cyrgani:builtin-macros-4

Conversation

@cyrgani

@cyrgani cyrgani commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Followup to #162234 with more cleanups and perf improvements.

@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Changes to the code generated for builtin derived traits.

cc @nnethercote

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2026
@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 21 candidates

cyrgani
cyrgani commented Sep 17, 2026
View reviewed changes
Comment thread tests/ui/stats/macro-stats.stderr
@@ -2,15 +2,15 @@ macro-stats ====================================================================
macro-stats MACRO EXPANSION STATS: macro_stats
macro-stats Macro Name Uses Lines Avg Lines Bytes Avg Bytes
macro-stats -----------------------------------------------------------------------------------
macro-stats #[derive(Clone)] 8 67 8.4 1_879 234.9
macro-stats #[derive(Clone)] 8 67 8.4 1_895 236.9

@cyrgani cyrgani Sep 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test shows a slight increase in size, but that is only because the types in the test all have one-or-two-letter names

View changes since the review

@clarfonthey

clarfonthey commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 17, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 17, 2026
@bors
Auto merge of #162925 - cyrgani:builtin-macros-4, r=<try>
34797f1 
even more cleanups for `rustc_builtin_macros`
@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 34797f1 (34797f1780452184438a4934a50dd0fbab5bb644)
Base parent: 76af58f (76af58f665c5cd76672e64ca118efbb0101fb224)

@rust-timer

rust-timer commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Queued 34797f1 with parent 76af58f, future comparison URL.
There are currently 22 preceding artifacts in the queue.
It will probably take at least ~16.8 hours until the benchmark run finishes.

@nnethercote

nnethercote commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cyrgani: The rustc_builtin_macros code has always been hard to navigate, so it's cool that you are making it better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mati865 mati865

Labels

S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyrgani @rustbot @clarfonthey @rust-timer @nnethercote @mati865