Skip to content

Update expect messages in path docs to better follow guidelines - #161415

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cdcp2:fix-path-expect-messages
Aug 21, 2026
Merged

Update expect messages in path docs to better follow guidelines#161415
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cdcp2:fix-path-expect-messages

Conversation

@cdcp2

@cdcp2 cdcp2 commented Aug 20, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Updates the .expect() messages in library/std/src/path.rs
to better follow the guidance for expect messages.

Related to #159751.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2026
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 20, 2026
@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @nia-e (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@nia-e

nia-e commented Aug 20, 2026

Copy link
Copy Markdown
Member

looks good, thanks for the PR ^^

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 176a865 has been approved by nia-e

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161415 - cdcp2:fix-path-expect-messages, r=…
9bbba38 
…nia-e

Update expect messages in path docs to better follow guidelines

Updates the `.expect()` messages in `library/std/src/path.rs`
to better follow the guidance for `expect` messages.

Related to rust-lang#159751.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 20, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 20, 2026
@bors
Auto merge of #161425 - JonathanBrouwer:rollup-KKnteRO, r=JonathanBro…
ed96418 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #152617 (std: implement `sleep_until` for Fuchsia)
 - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib)
 - #161277 (bootstrap: Move all non-module items out of the crate root)
 - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`)
 - #161368 (Double-word align `_Unwind_Exception`)
 - #161370 (Uplift rustfmt macro formatting fix)
 - #161378 (`FlowSensitiveAnalysis` cleanups)
 - #158032 (Offload expose device selection)
 - #158855 (Add `desktop` method to `CommandExt`)
 - #161199 (Add regression test for non lifetime binders)
 - #161302 (Add regression test for inconsistent import resolution from issue 147208)
 - #161329 (Add regression tests for a few fixed issues with E-needs-test)
 - #161330 (Add regression test for nested RPIT not an iterator ICE)
 - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`)
 - #161355 (Add file path to some archive build errors)
 - #161373 (Allow running EC2 jobs locally)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161415 - cdcp2:fix-path-expect-messages, r=…
af749d1 
…nia-e

Update expect messages in path docs to better follow guidelines

Updates the `.expect()` messages in `library/std/src/path.rs`
to better follow the guidance for `expect` messages.

Related to rust-lang#159751.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161415 - cdcp2:fix-path-expect-messages, r=…
eccead2 
…nia-e

Update expect messages in path docs to better follow guidelines

Updates the `.expect()` messages in `library/std/src/path.rs`
to better follow the guidance for `expect` messages.

Related to rust-lang#159751.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161415 - cdcp2:fix-path-expect-messages, r=…
2d4a221 
…nia-e

Update expect messages in path docs to better follow guidelines

Updates the `.expect()` messages in `library/std/src/path.rs`
to better follow the guidance for `expect` messages.

Related to rust-lang#159751.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161455 - JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #161259 (move some attribute related structs out of rustc_attr_ir)
 - #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - #159899 ( `GenericArgs::types` triage + possible fixes)
 - #160459 (Use attribute parser for `deprecated` attribute checking)
 - #160813 (Optimize linked list iterator performance)
 - #161271 (doc: document safety requirements for core WTF-8)
 - #161317 (LLVM 24: configure float-abi via module flag)
 - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - #161369 (Add regression test for confusing lifetime error message issue)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
 - #161438 (Change triagebot backport to ping T-libs-fcp)
 - #161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhpratt jhpratt mentioned this pull request Aug 21, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
a872286 
Rollup of 20 pull requests

Successful merges:

 - #161259 (move some attribute related structs out of rustc_attr_ir)
 - #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - #161161 (proc_macro: add support for 16-bit targets)
 - #159899 ( `GenericArgs::types` triage + possible fixes)
 - #160459 (Use attribute parser for `deprecated` attribute checking)
 - #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
 - #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
 - #160595 (Clarify `str::split_at` docs)
 - #160813 (Optimize linked list iterator performance)
 - #161271 (doc: document safety requirements for core WTF-8)
 - #161317 (LLVM 24: configure float-abi via module flag)
 - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - #161369 (Add regression test for confusing lifetime error message issue)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
 - #161438 (Change triagebot backport to ping T-libs-fcp)
 - #161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-bors Bot merged commit 0be64de into rust-lang:main Aug 21, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 21, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Unrolled build for #161415 in rollup 161458
ea81a23 
Rollup merge of #161415 - cdcp2:fix-path-expect-messages, r=nia-e

Update expect messages in path docs to better follow guidelines

Updates the `.expect()` messages in `library/std/src/path.rs`
to better follow the guidance for `expect` messages.

Related to #159751.
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1 
Rollup of 20 pull requests

Successful merges:

 - rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
 - rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
 - rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
 - rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
 - rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
 - rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
 - rust-lang/rust#160595 (Clarify `str::split_at` docs)
 - rust-lang/rust#160813 (Optimize linked list iterator performance)
 - rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
 - rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
 - rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
 - rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
 - rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
 - rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
 - rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
 - rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit to malezjaa/rust that referenced this pull request Aug 23, 2026
@bors @malezjaa
Auto merge of rust-lang#161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3 
Rollup of 20 pull requests

Successful merges:

 - rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
 - rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - rust-lang#161161 (proc_macro: add support for 16-bit targets)
 - rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
 - rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
 - rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
 - rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
 - rust-lang#160595 (Clarify `str::split_at` docs)
 - rust-lang#160813 (Optimize linked list iterator performance)
 - rust-lang#161271 (doc: document safety requirements for core WTF-8)
 - rust-lang#161317 (LLVM 24: configure float-abi via module flag)
 - rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - rust-lang#161369 (Add regression test for confusing lifetime error message issue)
 - rust-lang#161393 (Configure LLM policy URL for triagebot)
 - rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
 - rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
 - rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
 - rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)

implement [u8]::split_ascii_whitespace

format

fix
malezjaa pushed a commit to malezjaa/rust that referenced this pull request Aug 23, 2026
@bors @malezjaa
Auto merge of rust-lang#161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f 
Rollup of 20 pull requests

Successful merges:

 - rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
 - rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - rust-lang#161161 (proc_macro: add support for 16-bit targets)
 - rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
 - rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
 - rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
 - rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
 - rust-lang#160595 (Clarify `str::split_at` docs)
 - rust-lang#160813 (Optimize linked list iterator performance)
 - rust-lang#161271 (doc: document safety requirements for core WTF-8)
 - rust-lang#161317 (LLVM 24: configure float-abi via module flag)
 - rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - rust-lang#161369 (Add regression test for confusing lifetime error message issue)
 - rust-lang#161393 (Configure LLM policy URL for triagebot)
 - rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
 - rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
 - rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
 - rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)

implement [u8]::split_ascii_whitespace

format

fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nia-e nia-e

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cdcp2 @rustbot @nia-e