Hint that memchr returns an in-bounds index - #159784
Open
SomeFlyingThing wants to merge 5 commits into
Open
Conversation
rustbot
added
S-waiting-on-author
SomeFlyingThing
marked this pull request as ready for review
July 23, 2026 17:42
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @petrochenkov (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? libs |
Darksonn
reviewed
Jul 24, 2026
Member
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 28, 2026
…result-bounds, r=Darksonn Hint that memchr returns an in-bounds index `memchr_aligned` always returns an index within the input slice, but that fact was not visible to callers after inlining. Record the invariant with `assert_unchecked` so LLVM can simplify callers such as `str::find(char)` In x86_64 codegen, `find(char)` shrank from 463 to 377 bytes.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 28, 2026
…uwer Rollup of 5 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #160027 (Add regression test for #132767) - #160030 (Update `browser-ui-test` version to `0.25.0`) - #160046 (Improve consistency of attribute error messages (part 2)) - #160056 (Fix associated function suggestion for generic ADTs)
Contributor
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #160070 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#160070), which was unapproved. |
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memchr_alignedalways returns an index within the input slice, but that fact was not visible to callers after inlining. Record the invariant withassert_uncheckedso LLVM can simplify callers such asstr::find(char)In x86_64 codegen,
find(char)shrank from 463 to 377 bytes.