tidy: handle large numeric sort keys#159273
Draft
kn1g78 wants to merge 1 commit into
Draft
Conversation
rustbot
added
A-tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidy's alphabetical checker parsed numeric sort keys as
u64, which panicked when a marked list contained a number larger thanu64::MAX.Compare numeric sequences by their leading-zero-trimmed length and lexical value instead. This preserves the existing natural ordering and supports arbitrarily long ASCII digit sequences.
Added a regression test for values above
u64::MAX.Tests:
cargo test --offline --manifest-path src/tools/tidy/Cargo.tomlx test tidy