Skip to content

str: add ASCII fast path to word_to_titlecase#159271

Open
Rachit2323 wants to merge 1 commit into
rust-lang:mainfrom
Rachit2323:fix-titlecase-ascii-fastpath
Open

str: add ASCII fast path to word_to_titlecase#159271
Rachit2323 wants to merge 1 commit into
rust-lang:mainfrom
Rachit2323:fix-titlecase-ascii-fastpath

Conversation

@Rachit2323

@Rachit2323 Rachit2323 commented Jul 14, 2026

Copy link
Copy Markdown

The word_to_titlecase function had a FIXME comment since a long time asking to add a fast path for ASCII text.

Before this change, even simple English text like "hello world" was going through slow Unicode lookup tables. That was unnecessary.

This fixes it by using the same trick that to_lowercase already uses — plain English letters are now handled much faster, and only Greek/Chinese/etc still use the Unicode tables.

No behavior changes, just faster for normal English text.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 14, 2026
@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @clarfonthey (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

}

#[test]
fn word_to_titlecase() {

@clarfonthey clarfonthey Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to add titlecase tests, we should at least add some weird cases. What felt reasonable to test was the three LJ ligatures (lower lj, upper LJ, title Lj) and one character that decomposes into title case (lower ß, upper SS, title Ss):

  • ßljLJLj => Ssljljlj
  • ljLJLjß => Ljljljß
  • LJLjßlj => Ljljßlj
  • LjßljLJ => Ljßljlj

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants