Skip to content

Remove old MinGW workaround#158021

Open
mati865 wants to merge 1 commit into
rust-lang:mainfrom
mati865:mingw-remove-workaround
Open

Remove old MinGW workaround#158021
mati865 wants to merge 1 commit into
rust-lang:mainfrom
mati865:mingw-remove-workaround

Conversation

@mati865

@mati865 mati865 commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

View all comments

Before mingw-w64/mingw-w64@dbfdf80 mkstemp used by Binutils was not sufficiently collision resilient and that led to CI errors for us.

Our new baseline mingw-w64 toolchain's Binutils are built using mingw-w64 with the fix: niXman/mingw-builds#682
So, we should be able to get rid of it.

Fixes #108227

@mati865
Remove old mingw-w64 workaround
fddee44 
Before mingw-w64/mingw-w64@dbfdf80
mkstemp used by Binutils was not sufficiently
collision resilient and that led to CI errors for
us.

Our new baseline mingw-w64 toolchain's Binutils
are built using mingw-w64 with the fix:
niXman/mingw-builds#682
So, we should be able to get rid of it.
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 17, 2026
@mati865

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
@bors
Auto merge of #158021 - mati865:mingw-remove-workaround, r=<try>
1f917df 
Remove old MinGW workaround


try-job: *i686-mingw
try-job: x86_64-mingw
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment was marked as resolved.

Sign in to view
@mati865

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
@bors
Auto merge of #158021 - mati865:mingw-remove-workaround, r=<try>
97f8dbf 
Remove old MinGW workaround


try-job: *i686-mingw
try-job: *x86_64-mingw*
@rust-bors

This comment was marked as resolved.

Sign in to view
@mati865

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
@bors
Auto merge of #158021 - mati865:mingw-remove-workaround, r=<try>
4c59c62 
Remove old MinGW workaround


try-job: *i686-mingw
try-job: x86_64-mingw
@rust-bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@mati865

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
@bors
Auto merge of #158021 - mati865:mingw-remove-workaround, r=<try>
5346a35 
Remove old MinGW workaround


try-job: *i686-mingw
try-job: *x86_64-mingw*
@rust-bors

This comment was marked as resolved.

Sign in to view
@mati865

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
@bors
Auto merge of #158021 - mati865:mingw-remove-workaround, r=<try>
b4890a5 
Remove old MinGW workaround


try-job: *i686-mingw
try-job: *x86_64-mingw*
@rust-bors

This comment was marked as resolved.

Sign in to view
@mati865 mati865 marked this pull request as ready for review June 25, 2026 08:09
@rustbot

rustbot commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 25, 2026
@rustbot

rustbot commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

@mati865

mati865 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Github didn't realise #158020 which this PR is stacked upon, is already merged (even the hash is the same - b1483e3).

@mati865 mati865 closed this Jun 25, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2026
@mati865 mati865 reopened this Jun 25, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2026
@bjorn3

bjorn3 commented Jun 25, 2026

Copy link
Copy Markdown
Member

Before https://github.com/mingw-w64/mingw-w64/commit/ mkstemp

Looks like the exact commit got lost.

@mati865

mati865 commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Thanks, I didn't copy the message from the commit to description carefully enough. Fixed now.

@marcoieni

marcoieni commented Jul 2, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist-aarch64-llvm-mingw

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 2, 2026
@bors
Auto merge of #158021 - mati865:mingw-remove-workaround, r=<try>
98fa464 
Remove old MinGW workaround


try-job: dist-aarch64-llvm-mingw
@rust-bors

rust-bors Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 98fa464 (98fa46412fc20c45544f297ff2b2a381b756a770)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

@marcoieni

marcoieni commented Jul 2, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup=always

@rust-bors

rust-bors Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit fddee44 has been approved by marcoieni

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158021 - mati865:mingw-remove-workaround, r…
e601ae0 
…=marcoieni

Remove old MinGW workaround

Before mingw-w64/mingw-w64@dbfdf80 mkstemp used by Binutils was not sufficiently collision resilient and that led to CI errors for us.

Our new baseline mingw-w64 toolchain's Binutils are built using mingw-w64 with the fix: niXman/mingw-builds#682
So, we should be able to get rid of it.

Fixes rust-lang#108227
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 2, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Jul 3, 2026
@bors
Auto merge of #158700 - JonathanBrouwer:rollup-HusuWnV, r=JonathanBro…
34fd20b 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #155429 (Support `u128`/`i128` c-variadic arguments)
 - #158100 (Emit retags in codegen to support BorrowSanitizer (part 4))
 - #158494 (Improve E0277 diagnostics for conditionally implemented traits)
 - #158606 (use ProjectionPredicate instead of AliasRelate)
 - #158627 (Simplify option-iterator flattening in the compiler)
 - #158658 (Update LLVM submodule)
 - #158665 (Revert "Remove redundant dyn-compatibility check.")
 - #158021 (Remove old MinGW workaround)
 - #158473 (Add `riscv32imfc-unknown-none-elf` bare-metal target)
 - #158549 (process::exec: using appropriate exit code on vxworks.)
 - #158585 (Improve diagnostic for too many super keywords)
 - #158637 (hir_ty_lowering: avoid self type lookup for inherent aliases)
 - #158651 (ptr doc: reduce use of unsafe block to where needed)
 - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`)
 - #158674 (library: Polish transmute's `split_at_stdlib` example)
 - #158677 (Add extra splat tests)
 - #158680 (Avoid ICE for `NonZero<char>` in improper_ctypes)
 - #158681 (Remove unnecessary `Hash` derives from MIR types)
 - #158682 (Avoid delayed bug for disabled on_type_error arguments)
 - #158684 (Add missing generic test coverage for ```#[splat]```)
 - #158687 (Streamline `MacEager`)
 - #158688 (Cleanup attribute docs and add links to other mentioned attributes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@marcoieni marcoieni

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: spurious error building LLVM on mingw: ranlib.exe: could not create temporary file whilst writing archive: no more archived files

5 participants

@mati865 @rust-log-analyzer @rustbot @bjorn3 @marcoieni