Skip to content

stabilize never type - #155499

Open
WaffleLapkin wants to merge 19 commits into
rust-lang:mainfrom
WaffleLapkin:stabilize-never-type
Open

stabilize never type#155499
WaffleLapkin wants to merge 19 commits into
rust-lang:mainfrom
WaffleLapkin:stabilize-never-type

Conversation

@WaffleLapkin

@WaffleLapkin WaffleLapkin commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

View all comments

This PR

Cat

52270233795_5979a3174d_b

Tracking

FCPs

Related changes

Experiments

Closes #35121
Closes #148922

@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 18, 2026
@rustbot

This comment has been minimized.

Sign in to view
@WaffleLapkin
WaffleLapkin marked this pull request as draft April 18, 2026 22:14
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2026
@WaffleLapkin

WaffleLapkin commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 18, 2026
@bors
Auto merge of #155499 - WaffleLapkin:stabilize-never-type, r=<try>
1c4199d 
[experiment][0] nya
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1c4199d (1c4199da70f816f2239f41c55168ff75a3663718, parent: b2f1ccf524a3a4cf9c34545167cc23b659cf1cbd)

@WaffleLapkin
WaffleLapkin force-pushed the stabilize-never-type branch from 2895d33 to 3e8df8d Compare April 19, 2026 01:05
@WaffleLapkin

WaffleLapkin commented Apr 19, 2026

Copy link
Copy Markdown
Member Author

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-154887/retry-regressed-list.txt

@craterbot

craterbot commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-155499 created and queued.
🤖 Automatically detected try build 1c4199d
⚠️ Try build based on commit 2895d33, but latest commit is 3e8df8d. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2026
@craterbot

craterbot commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-155499 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-155499 is completed!
📊 3277 regressed and 0 fixed (9024 total)
📊 1149 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-155499/retry-regressed-list.txt ↩

@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@WaffleLapkin WaffleLapkin added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2026
JonathanBrouwer
JonathanBrouwer reviewed Aug 20, 2026
View reviewed changes
Comment thread src/tools/clippy/tests/ui/zero_repeat_side_effects_unfixable.stderr
|
LL ~ panic!();
LL + let _data: [!; 0] = [];
|

@JonathanBrouwer JonathanBrouwer Aug 20, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I wonder how this changed

View changes since the review

@JonathanBrouwer JonathanBrouwer Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the suggestion was previously not made because ! was unnameable, that is very cool. This suggestion is no longer unfixable so we can move it to the normal zero_repeat_side_effects.rs test

@JonathanBrouwer

JonathanBrouwer commented Aug 20, 2026

Copy link
Copy Markdown
Member

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 20, 2026
@bors
Auto merge of #155499 - WaffleLapkin:stabilize-never-type, r=<try>
565d1d2 
stabilize never type


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-1
try-job: aarch64-apple-2
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: i686-msvc-2
JonathanBrouwer
JonathanBrouwer requested changes Aug 20, 2026
View reviewed changes

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the entire diff now :)

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026
@rust-bors

rust-bors Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 565d1d2 (565d1d2f5710463a3a055f4d2d767dcc75e78a0f)
Base parent: 8925ea3 (8925ea358a0f265ca61026aadc7ecc506c545cbe)

@rust-bors

rust-bors Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161043) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

tshepang
tshepang reviewed Aug 21, 2026
View reviewed changes
Comment thread tests/ui/never_type/fallback_change/diverging-fallback-unconstrained-return.rs
//
//@ revisions: e2021 e2024
//@[e2024] edition: 2024
//@ edition: 2018..2024

@tshepang tshepang Aug 21, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this test ran on edition 2015, even though the revision name implied (before this change) that 2021 is the lowest edition that is applicable

View changes since the review

tshepang
tshepang reviewed Aug 21, 2026
View reviewed changes
Comment thread tests/ui/never_type/fallback_change/lint-never-type-fallback-flowing-into-unsafe.rs
@@ -1,5 +1,4 @@
//@ revisions: e2015 e2024
//@[e2024] edition:2024
//@ edition: 2015..2024

@tshepang tshepang Aug 21, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test will accidentally be missed when the next edition happens
we can use 2015.. to say all-of-em

View changes since the review

@theemathas theemathas mentioned this pull request Aug 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@traviscross traviscross traviscross left review comments
@theemathas theemathas theemathas left review comments
@Nadrieril Nadrieril Nadrieril left review comments
@JonathanBrouwer JonathanBrouwer JonathanBrouwer requested changes
+4 more reviewers
@ehuss ehuss ehuss left review comments
@tshepang tshepang tshepang left review comments
@jplatte jplatte jplatte left review comments
@seritools seritools seritools left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@tmandry tmandry

@JonathanBrouwer JonathanBrouwer

@jackh726 jackh726

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. needs-reference-pr This language change needs an approved Reference PR to proceed. S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. to-announce Announce this issue on triage meeting WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking Issue for never type fallback change Tracking issue for promoting ! to a type (RFC 1216)