Skip to content

refactor - moving check_stability check to parse_stability#154015

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
josetorrs:refactor-parse-stability
Mar 21, 2026
Merged

refactor - moving check_stability check to parse_stability#154015
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
josetorrs:refactor-parse-stability

Conversation

@josetorrs
Copy link
Contributor

@josetorrs josetorrs commented Mar 17, 2026 •
edited
Loading

This PR is part of issue #153101 and by extension this #131229 as well

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@rustbot rustbot assigned JonathanBrouwer and unassigned jackh726 Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

JonathanBrouwer
JonathanBrouwer requested changes Mar 19, 2026
View reviewed changes
compiler/rustc_passes/src/check_attr.rs Outdated
) => self.check_stability(*attr_span, span, level, *feature),
AttributeKind::Stability { .. }
| AttributeKind::RustcConstStability { .. },
) => {}
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a separate empty arm here, could you add these attributes to the list of ignored attributes below?

Copy link
Contributor Author

@josetorrs josetorrs Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. also added the slash here: 38f9b79

compiler/rustc_attr_parsing/src/attributes/stability.rs Outdated
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but happened to see this, could you fix this doc comment? It's missing a slash

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 20, 2026
Open
28 tasks
@josetorrs
Copy link
Contributor Author

josetorrs commented Mar 20, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2026
@josetorrs josetorrs force-pushed the refactor-parse-stability branch from 822232f to 3ea7d1e Compare March 20, 2026 18:04
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 20, 2026
JonathanBrouwer
JonathanBrouwer approved these changes Mar 20, 2026
View reviewed changes
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

📌 Commit 3ea7d1e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 20, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 20, 2026
@bors
Auto merge of #154151 - JonathanBrouwer:rollup-qLQ5uET, r=JonathanBro…
9e0a42c 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153828 (Guard patterns: lowering to THIR)
 - #154015 (refactor - moving `check_stability` check to `parse_stability`)
 - #154119 (llvm: Update `reliable_f128` configuration for LLVM22 on Sparc)
 - #154138 (vec::Drain::fill: avoid reference to uninitialized memory)
 - #154143 (test copy_specializes_from_vecdeque: reduce iteration count for Miri)
@rust-bors rust-bors bot merged commit 7ba136f into rust-lang:main Mar 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@josetorrs @rustbot @JonathanBrouwer @jackh726