Give a better error when updating a submodule fails#153060
Open
jyn514 wants to merge 1 commit intorust-lang:mainfrom
Open
Give a better error when updating a submodule fails#153060jyn514 wants to merge 1 commit intorust-lang:mainfrom
jyn514 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Previously this would sometimes just say "unexpected output ``", which was extremely unhelpful. The actual issue was that I had a `.jj` directory but not a `.git` directory, so it couldn't run `git submodule update.`
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
approved these changes
Feb 25, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 25, 2026
Give a better error when updating a submodule fails Previously this would sometimes just say "unexpected output ``", which was extremely unhelpful. The actual issue was that I had a `.jj` directory but not a `.git` directory, so it couldn't run `git submodule update.`
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Rollup of 12 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152418 (`BTreeMap::merge` optimized) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #152952 (mGCA: improve ogca diagnostic message ) - #152977 (Fix relative path handling for --extern-html-root-url) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153032 (Fix attribute parser and kind names.) - #153051 (Migration of `LintDiagnostic` - part 3) - #153060 (Give a better error when updating a submodule fails)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this would sometimes just say "unexpected output ``", which was extremely unhelpful. The actual issue was that I had a
.jjdirectory but not a `.git` directory, so it couldn't run `git submodule update.`