Superficial tweaks to the query modifier docs in rustc_middle::query::modifiers#153004
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Feb 24, 2026
Merged
Superficial tweaks to the query modifier docs in rustc_middle::query::modifiers#153004rust-bors[bot] merged 3 commits intorust-lang:mainfrom
rustc_middle::query::modifiers#153004rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
This massively speeds up find-all-references in rust-analyzer, from taking several seconds to being near-instant.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Zalathar
added
the
A-query-system
wesleywiser
approved these changes
Feb 23, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
…uwer Rollup of 14 pull requests Successful merges: - #153007 (`rust-analyzer` subtree update) - #152670 (Simplify ThinLTO handling) - #152768 (Enable autodiff in ci for all major os) - #152908 (Enable rust.remap-debuginfo in the dist profile) - #152999 (Check importing `crate`/`$crate`/`super` after handling `self`) - #152003 (Reflection TypeId::trait_info_of) - #152976 (Revert relative paths for std links in rustc-docs) - #152985 (Port `#[feature]` to the new attribute system) - #152989 (Port `#[rustc_inherit_overflow_checks]` to the new attribute parsers) - #152991 (fix interpreter tracing output) - #153004 (Superficial tweaks to the query modifier docs in `rustc_middle::query::modifiers`) - #153008 (bootstrap.compiler.toml: update name of primary branch) - #153016 (Migration of `LintDiagnostic` - part 2) - #153020 (rustdoc: Improve sentence for documented empty impl blocks) Failed merges: - #152988 (Port `#[register_tool]` to the new attribute system)
Member
Author
|
r? wesleywiser |
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
…uwer Rollup of 14 pull requests Successful merges: - #153007 (`rust-analyzer` subtree update) - #152670 (Simplify ThinLTO handling) - #152768 (Enable autodiff in ci for all major os) - #152908 (Enable rust.remap-debuginfo in the dist profile) - #152999 (Check importing `crate`/`$crate`/`super` after handling `self`) - #152003 (Reflection TypeId::trait_info_of) - #152976 (Revert relative paths for std links in rustc-docs) - #152985 (Port `#[feature]` to the new attribute system) - #152989 (Port `#[rustc_inherit_overflow_checks]` to the new attribute parsers) - #152991 (fix interpreter tracing output) - #153004 (Superficial tweaks to the query modifier docs in `rustc_middle::query::modifiers`) - #153008 (bootstrap.compiler.toml: update name of primary branch) - #153016 (Migration of `LintDiagnostic` - part 2) - #153020 (rustdoc: Improve sentence for documented empty impl blocks) Failed merges: - #152988 (Port `#[register_tool]` to the new attribute system)
rust-timer
added a commit
that referenced
this pull request
Feb 24, 2026
Rollup merge of #153004 - Zalathar:tweak-modifiers, r=wesleywiser Superficial tweaks to the query modifier docs in `rustc_middle::query::modifiers` This PR sorts the dummy items in the `modifiers` module, makes them non-pub to speed up find-all-references, and adds some extra explanation of what the dummy modifier items are for. (These dummy items mostly just exist to carry documentation, and have no actual effect on compiler behaviour.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sorts the dummy items in the
modifiersmodule, makes them non-pub to speed up find-all-references, and adds some extra explanation of what the dummy modifier items are for.(These dummy items mostly just exist to carry documentation, and have no actual effect on compiler behaviour.)