rustc_expand: improve diagnostics for non-repeatable metavars#152679
Open
Unique-Usman wants to merge 1 commit intorust-lang:mainfrom
Open
rustc_expand: improve diagnostics for non-repeatable metavars#152679Unique-Usman wants to merge 1 commit intorust-lang:mainfrom
Unique-Usman wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @BoxyUwU rustbot has assigned @BoxyUwU. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @estebank |
Contributor
Author
|
This is rebased on top of ->791ee34 |
This comment has been minimized.
This comment has been minimized.
Unique-Usman
force-pushed
the
ua/decmacrounrepeatable
branch
from
0fbe120 to
81f68bb
Compare
This comment has been minimized.
This comment has been minimized.
Unique-Usman
force-pushed
the
ua/decmacrounrepeatable
branch
from
81f68bb to
60060dd
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
estebank
approved these changes
Feb 23, 2026
Unique-Usman
force-pushed
the
ua/decmacrounrepeatable
branch
from
9704509 to
d4e8858
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Unique-Usman
force-pushed
the
ua/decmacrounrepeatable
branch
from
d4e8858 to
93b9973
Compare
Contributor
Author
|
@estebank - this is ready to land. Thank you for the review. |
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
Author
|
this #47452 should be closed now ? |
Contributor
|
Updated the description so that when the PR merges the ticket gets autoclosed. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 24, 2026
…le, r=estebank rustc_expand: improve diagnostics for non-repeatable metavars Fix rust-lang#47452.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Rollup of 8 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153051 (Migration of `LintDiagnostic` - part 3)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 25, 2026
…le, r=estebank rustc_expand: improve diagnostics for non-repeatable metavars Fix rust-lang#47452.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #47452.