Skip to content

Comments

Remove the translation -Z options and the Translator type. #152455

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:remove_translation
Feb 21, 2026
Merged

Remove the translation -Z options and the Translator type. #152455
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:remove_translation

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 10, 2026 •
edited
Loading

This PR implements MCP rust-lang/compiler-team#967

It is split up into individually reviewable commits, each commit passes tests:

  • 6782119 Removes the translation compiler options from the session
  • 8f300d0 Removes the now empty Translator type
  • ab715c5 Renames translate_message to format_diag_message, as the function no longer does any translation
  • 8bcbc3f Removes a section describing the removed compiler options from the rustc dev guide

@JonathanBrouwer JonathanBrouwer added needs-mcp This change is large enough that it needs a major change proposal before starting work. S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. labels Feb 10, 2026
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Feb 10, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 20, 2026

r? @jdonszelmann
The MCP for this will be accepted today if no one submits any last-moment concerns, so don't R+ yet but review would be appreciated :)

@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review February 20, 2026 09:56
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

rustc_errors::emitter was changed

cc @Muscraft

rustc_errors::translation was changed

cc @davidtwco, @TaKO8Ki

rustc_error_messages was changed

cc @davidtwco, @TaKO8Ki

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 20, 2026
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 20, 2026

r=me when fcp passes

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 20, 2026

@bors r+

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 20, 2026

@bors r=jdonszelmann rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-MCP.

1 similar comment
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-MCP.

@JonathanBrouwer JonathanBrouwer removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Feb 20, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 20, 2026

@bors r=jdonszelmann rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit 8bcbc3f has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2026
This was referenced Feb 20, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 21, 2026
@bors
Auto merge of #152924 - JonathanBrouwer:rollup-vnwkCh0, r=JonathanBro…
1c00e98 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #146832 (Not linting irrefutable_let_patterns on let chains)
 - #146972 (Support importing path-segment keyword with renaming)
 - #152241 (For panic=unwind on Wasm targets, define __cpp_exception tag)
 - #152527 (Remove -Zemit-thin-lto flag)
 - #152769 (Do not cancel try builds after first job failure)
 - #152907 (Add tests for delegation generics)
 - #152455 (Remove the translation `-Z` options and the `Translator` type. )
 - #152813 (Skip the `use_existential_projection_new_instead` field in the `Debug` impl)
 - #152912 (Expose Span for all DefIds in rustc_public)
@rust-bors rust-bors bot merged commit b0cdafb into rust-lang:main Feb 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 21, 2026
rust-timer added a commit that referenced this pull request Feb 21, 2026
@rust-timer
Unrolled build for #152455
30613dd 
Rollup merge of #152455 - JonathanBrouwer:remove_translation, r=jdonszelmann

Remove the translation `-Z` options and the `Translator` type.

This PR implements MCP rust-lang/compiler-team#967

It is split up into individually reviewable commits, each commit passes tests:

* 6782119 Removes the translation compiler options from the session
* 8f300d0 Removes the now empty `Translator` type
* ab715c5 Renames `translate_message` to `format_diag_message`, as the function no longer does any translation
* 8bcbc3f Removes a section describing the removed compiler options from the rustc dev guide
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152924 - JonathanBrouwer:rollup-vnwkCh0, r=JonathanBro…
1df0436 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#146832 (Not linting irrefutable_let_patterns on let chains)
 - rust-lang/rust#146972 (Support importing path-segment keyword with renaming)
 - rust-lang/rust#152241 (For panic=unwind on Wasm targets, define __cpp_exception tag)
 - rust-lang/rust#152527 (Remove -Zemit-thin-lto flag)
 - rust-lang/rust#152769 (Do not cancel try builds after first job failure)
 - rust-lang/rust#152907 (Add tests for delegation generics)
 - rust-lang/rust#152455 (Remove the translation `-Z` options and the `Translator` type. )
 - rust-lang/rust#152813 (Skip the `use_existential_projection_new_instead` field in the `Debug` impl)
 - rust-lang/rust#152912 (Expose Span for all DefIds in rustc_public)
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 23, 2026
@bors
Auto merge of #152924 - JonathanBrouwer:rollup-vnwkCh0, r=JonathanBro…
ec1b20b 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#146832 (Not linting irrefutable_let_patterns on let chains)
 - rust-lang/rust#146972 (Support importing path-segment keyword with renaming)
 - rust-lang/rust#152241 (For panic=unwind on Wasm targets, define __cpp_exception tag)
 - rust-lang/rust#152527 (Remove -Zemit-thin-lto flag)
 - rust-lang/rust#152769 (Do not cancel try builds after first job failure)
 - rust-lang/rust#152907 (Add tests for delegation generics)
 - rust-lang/rust#152455 (Remove the translation `-Z` options and the `Translator` type. )
 - rust-lang/rust#152813 (Skip the `use_existential_projection_new_instead` field in the `Debug` impl)
 - rust-lang/rust#152912 (Expose Span for all DefIds in rustc_public)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic needs-mcp This change is large enough that it needs a major change proposal before starting work. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rust-log-analyzer @rustbot @jdonszelmann