chore: clearify tidy's error message #152202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-tidy
Collaborator
|
r? @Zalathar rustbot has assigned @Zalathar. Use Why was this reviewer chosen?The reviewer was selected based on:
|
src/tools/tidy/src/ui_tests.rs
Outdated
| { | ||
| check.error(format!( | ||
| "file `tests/{stripped_path}` must begin with a descriptive name, consider `{{reason}}-issue-{issue_n}.rs`", | ||
| "the name of the file `tests/{stripped_path}` must begin with a descriptive prefix, consider `{{reason}}-issue-{issue_n}.rs`", |
Member
There was a problem hiding this comment.
"prefix" is misleading as it is not essential that it includes issue-{NN} as part of the filename and thus there is no "prefix" if it's the entire thing.
Contributor
Author
There was a problem hiding this comment.
what do you think would be a good error here?
Member
There was a problem hiding this comment.
Mm. If I had my druthers, it would be "test filenames should be descriptive instead of context-free integers", but that's probably too snarky.
jieyouxu
reviewed
Feb 6, 2026
Member
|
r? me @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
chore: clearify tidy's error message it took me a while to realize this error was due to the name of the file, not the file's content
This was referenced Feb 6, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…uwer Rollup of 13 pull requests Successful merges: - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152140 (Hard code the error code registry for custom drivers) - #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152182 (update compiler stable backport zulip msg) - #152184 (Port rustc_abi to the attribute parser) - #152195 (update openmp/offload builds to LLVM 22, Part 1) - #152202 (chore: clearify tidy's error message) Failed merges: - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152212 (Port some attributes to the attr parser)
rust-timer
added a commit
that referenced
this pull request
Feb 6, 2026
Rollup merge of #152202 - nyurik:better-msg, r=jieyouxu chore: clearify tidy's error message it took me a while to realize this error was due to the name of the file, not the file's content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it took me a while to realize this error was due to the name of the file, not the file's content