Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 4, 2026

And do some cleanups enabled by this.

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

rustc_errors::emitter was changed

cc @Muscraft

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Feb 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the driver_fixed_error_codes branch 2 times, most recently from c6eefea to 7a13511 Compare February 4, 2026 20:45
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the driver_fixed_error_codes branch from 7a13511 to 2f124a3 Compare February 4, 2026 21:21
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the driver_fixed_error_codes branch from 2f124a3 to b73fe09 Compare February 5, 2026 10:00
@rust-log-analyzer

This comment has been minimized.

And move try_find_description to rustc_errors::codes.
@bjorn3 bjorn3 force-pushed the driver_fixed_error_codes branch from b73fe09 to 639cb69 Compare February 5, 2026 10:54
@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 6, 2026

📌 Commit 639cb69 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
 - #149329 (Mark match arms in try and for as being from desugarings.)
 - #151474 (Minor structural improvements)
 - #152107 (Convert to inline diagnostics in `rustc_borrowck`)
 - #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
 - #152136 (Consolidate type const checks on `tcx.is_type_const`)
 - #152140 (Hard code the error code registry for custom drivers)
 - #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md)
 - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
 - #152182 (update compiler stable backport zulip msg)
 - #152184 (Port rustc_abi to the attribute parser)
 - #152195 (update openmp/offload builds to LLVM 22, Part 1)
 - #152202 (chore: clearify tidy's error message)

Failed merges:

 - #151744 (fix refining_impl_trait suggestion with return_type_notation)
 - #152212 (Port some attributes to the attr parser)
@rust-bors rust-bors bot merged commit d96d73f into rust-lang:main Feb 6, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 6, 2026
rust-timer added a commit that referenced this pull request Feb 6, 2026
Rollup merge of #152140 - bjorn3:driver_fixed_error_codes, r=jdonszelmann

Hard code the error code registry for custom drivers

And do some cleanups enabled by this.
@bjorn3 bjorn3 deleted the driver_fixed_error_codes branch February 6, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants