Skip to content

Comments

Fix doc link used in suggestion for pinning self#150562

Open
Trivaxy wants to merge 1 commit intorust-lang:mainfrom
Trivaxy:poll-doc-patch
Open

Fix doc link used in suggestion for pinning self#150562
Trivaxy wants to merge 1 commit intorust-lang:mainfrom
Trivaxy:poll-doc-patch

Conversation

@Trivaxy
Copy link

@Trivaxy Trivaxy commented Jan 1, 2026

Fixes #147901

The old suggestion linked to a documentation page that no longer exists. Presumably, this is the better place to link to now

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 1, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2026

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@reddevilmidzy
Copy link
Member

Please squash it into one commit

@apiraino
Copy link
Contributor

apiraino commented Feb 24, 2026

@bors r=apiraino

@rust-bors

This comment was marked as outdated.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 24, 2026
Fix doc link used in suggestion for pinning self

Fixes rust-lang#147901

The old suggestion linked to a documentation page that [no longer exists](https://rust-lang.github.io/async-book/04_pinning/01_chapter.html#pinning-in-practice). Presumably, [this](https://rust-lang.github.io/async-book/part-reference/pinning.html) is the better place to link to now
rust-bors bot pushed a commit that referenced this pull request Feb 25, 2026
Rollup of 8 pull requests

Successful merges:

 - #149169 (ptr::replace: make calls on ZST null ptr not UB)
 - #150562 (Fix doc link used in suggestion for pinning self)
 - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars)
 - #153017 (Implement debuginfo for unsafe binder types)
 - #152868 (delete some very old trivial `Box` tests)
 - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`)
 - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
 - #153051 (Migration of `LintDiagnostic` - part 3)
@jhpratt
Copy link
Member

jhpratt commented Feb 25, 2026

Looks like bors didn't pick up the edit. Let's attribute the approval properly.

@bors r=apiraino

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 25, 2026

📌 Commit 9014fda has been approved by apiraino

It is now in the queue for this repository.

jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 25, 2026
Fix doc link used in suggestion for pinning self

Fixes rust-lang#147901

The old suggestion linked to a documentation page that [no longer exists](https://rust-lang.github.io/async-book/04_pinning/01_chapter.html#pinning-in-practice). Presumably, [this](https://rust-lang.github.io/async-book/part-reference/pinning.html) is the better place to link to now
rust-bors bot pushed a commit that referenced this pull request Feb 25, 2026
Rollup of 12 pull requests

Successful merges:

 - #149169 (ptr::replace: make calls on ZST null ptr not UB)
 - #150562 (Fix doc link used in suggestion for pinning self)
 - #152418 (`BTreeMap::merge` optimized)
 - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars)
 - #152952 (mGCA: improve ogca diagnostic message )
 - #152977 (Fix relative path handling for --extern-html-root-url)
 - #153017 (Implement debuginfo for unsafe binder types)
 - #152868 (delete some very old trivial `Box` tests)
 - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`)
 - #153032 (Fix attribute parser and kind names.)
 - #153051 (Migration of `LintDiagnostic` - part 3)
 - #153060 (Give a better error when updating a submodule fails)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help message in compiler error leads to a 404

7 participants