Skip to content

Conversation

@GoldsteinE
Copy link
Contributor

@GoldsteinE GoldsteinE commented Nov 11, 2025

This stabilizes Vec::into_raw_parts() and String::into_raw_parts() per FCP in #65816 (comment). While this does not stabilize Vec::into_parts(), I fixed up the examples that said they were waiting for vec_into_raw_parts. As Vec::from_parts() and Vec::into_parts() are covered by the same feature box_vec_non_null, any doctest that uses Vec::from_parts() can also use Vec::into_parts() (and same for allocator-aware versions).

Closes #65816

@rustbot modify labels: +T-libs-api

@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 11, 2025
@GoldsteinE
Copy link
Contributor Author

(“Changes in intrinsics” only concern documentation for transmute that explains how to transmute vectors safely)

@rust-log-analyzer

This comment has been minimized.

@GoldsteinE GoldsteinE force-pushed the stabilize-vec-into-raw-parts branch from 8f5d6c0 to ac9bb13 Compare November 11, 2025 17:24
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 15, 2025

📌 Commit ac9bb13 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 15, 2025
…parts, r=Mark-Simulacrum

Stabilize vec_into_raw_parts

This stabilizes `Vec::into_raw_parts()` and `String::into_raw_parts()` per FCP in rust-lang#65816 (comment). While this _does not_ stabilize `Vec::into_parts()`, I fixed up the examples that said they were waiting for `vec_into_raw_parts`. As `Vec::from_parts()` and `Vec::into_parts()` are covered by the same feature `box_vec_non_null`, any doctest that uses `Vec::from_parts()` can also use `Vec::into_parts()` (and same for allocator-aware versions).

Closes rust-lang#65816

`@rustbot` modify labels: +T-libs-api
bors added a commit that referenced this pull request Nov 16, 2025
Rollup of 10 pull requests

Successful merges:

 - #148416 (`vec_recycle`: implementation)
 - #148522 (Micro-optimize rustdoc search index parsing)
 - #148827 (Stabilize vec_into_raw_parts)
 - #148832 (Bump library dependencies)
 - #148836 (tweak primitive reference docs)
 - #148859 (Fix overflow-checks test for RISC-V target)
 - #148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS)
 - #148956 (re-enable wasm abi test)
 - #148963 (runtest.rs: remove redundant check)
 - #148968 (Add another *ExprWithBlock* test for `try` blocks)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 16, 2025
Rollup of 11 pull requests

Successful merges:

 - #148416 (`vec_recycle`: implementation)
 - #148522 (Micro-optimize rustdoc search index parsing)
 - #148827 (Stabilize vec_into_raw_parts)
 - #148832 (Bump library dependencies)
 - #148836 (tweak primitive reference docs)
 - #148859 (Fix overflow-checks test for RISC-V target)
 - #148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS)
 - #148956 (re-enable wasm abi test)
 - #148963 (runtest.rs: remove redundant check)
 - #148968 (Add another *ExprWithBlock* test for `try` blocks)
 - #148984 (chore: Update annotate-snippets to 0.12.9)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec2f739 into rust-lang:main Nov 16, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 16, 2025
rust-timer added a commit that referenced this pull request Nov 16, 2025
Rollup merge of #148827 - GoldsteinE:stabilize-vec-into-raw-parts, r=Mark-Simulacrum

Stabilize vec_into_raw_parts

This stabilizes `Vec::into_raw_parts()` and `String::into_raw_parts()` per FCP in #65816 (comment). While this _does not_ stabilize `Vec::into_parts()`, I fixed up the examples that said they were waiting for `vec_into_raw_parts`. As `Vec::from_parts()` and `Vec::into_parts()` are covered by the same feature `box_vec_non_null`, any doctest that uses `Vec::from_parts()` can also use `Vec::into_parts()` (and same for allocator-aware versions).

Closes #65816

``@rustbot`` modify labels: +T-libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue for vec_into_raw_parts

5 participants