Skip to content

Enable std file locking functions on AIX #148619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable std file locking functions on AIX #148619

wants to merge 1 commit into from
+10 −0

Conversation

@amy-kwan
Copy link
Contributor

@amy-kwan amy-kwan commented Nov 7, 2025

This patch enables the std locking functions on AIX by including AIX on the list of supported targets for the locking functions. Excluding AIX from the std locking functions results to compilation errors such as: ("try_lock() not supported").

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 7, 2025
@amy-kwan
Enable std locking functions on AIX
b827732 
This patch enables the std locking functions on AIX by including AIX on the list
of supported targets for the locking functions. Excluding AIX from the std
locking functions results to compilation errors such as: ("try_lock() not supported").
@hkBst
Copy link
Member

hkBst commented Nov 7, 2025

@rustbot label +O-aix
cc @Noratrieb (since you seem to have access to this hardware)

@rustbot rustbot added the O-aix OS: Big Blue's Advanced Interactive eXecutive.. label Nov 7, 2025
@Noratrieb
Copy link
Member

Noratrieb commented Nov 7, 2025 •
edited
Loading

I do very much not have access to that hardware or any knowledge about AIX :D.

@daltenty @gilamn5tr as maintainers, I can approve the PR if you agree

@Noratrieb
Copy link
Member

Noratrieb commented Nov 7, 2025

r? Noratrieb

@rustbot rustbot assigned Noratrieb and unassigned joboet Nov 7, 2025
@hkBst
Copy link
Member

hkBst commented Nov 7, 2025

@Noratrieb Apologies for the misunderstanding. I assumed so because of #143443

@workingjubilee
Copy link
Member

workingjubilee commented Nov 8, 2025

I am pretty sure the IBM employee has access to an AIX implementation, and in any case, the worst this can do is change a build-fail to a build-fail.

@hkBst Pretty sure that was just cross-compiling (and probably not even artifact-producing).

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 8, 2025

📌 Commit b827732 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2025
@workingjubilee
Copy link
Member

workingjubilee commented Nov 8, 2025

amy-kwan should probably be a listed maintainer for the target but that is technically not obligatory.

jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 8, 2025
@jhpratt
Rollup merge of rust-lang#148619 - amy-kwan:amyk/AddLockingFunctions_…
2a08e0b 
…AIX, r=workingjubilee

Enable std locking functions on AIX

This patch enables the std locking functions on AIX by including AIX on the list of supported targets for the locking functions. Excluding AIX from the std locking functions results to compilation errors such as: ("try_lock() not supported").
@jhpratt jhpratt mentioned this pull request Nov 8, 2025
Closed
bors added a commit that referenced this pull request Nov 8, 2025
@bors
Auto merge of #148686 - jhpratt:rollup-jlh9fj9, r=jhpratt
939844a 
Rollup of 16 pull requests

Successful merges:

 - #147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - #147686 (update isolate_highest_one for NonZero<T>)
 - #148020 (Show backtrace on allocation failures when possible)
 - #148204 (Modify contributor email entries in .mailmap)
 - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - #148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names)
 - #148555 (Fix rust-by-example spanish translation)
 - #148556 (Fix suggestion for returning async closures)
 - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)
 - #148612 (Add note for identifier with attempted hygiene violation)
 - #148613 (Switch hexagon targets to rust-lld)
 - #148619 (Enable std locking functions on AIX)
 - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`)
 - #148649 (don't completely reset `HeadUsages`)
 - #148675 (Remove eslint-js from npm dependencies)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#148619 - amy-kwan:amyk/AddLockingFunctions_…
426f64b 
…AIX, r=workingjubilee

Enable std locking functions on AIX

This patch enables the std locking functions on AIX by including AIX on the list of supported targets for the locking functions. Excluding AIX from the std locking functions results to compilation errors such as: ("try_lock() not supported").
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#148619 - amy-kwan:amyk/AddLockingFunctions_…
ac2fc2b 
…AIX, r=workingjubilee

Enable std locking functions on AIX

This patch enables the std locking functions on AIX by including AIX on the list of supported targets for the locking functions. Excluding AIX from the std locking functions results to compilation errors such as: ("try_lock() not supported").
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2025
Open
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 9, 2025
@Zalathar
Rollup merge of rust-lang#148619 - amy-kwan:amyk/AddLockingFunctions_…
9663de0 
…AIX, r=workingjubilee

Enable std locking functions on AIX

This patch enables the std locking functions on AIX by including AIX on the list of supported targets for the locking functions. Excluding AIX from the std locking functions results to compilation errors such as: ("try_lock() not supported").
@Zalathar Zalathar mentioned this pull request Nov 9, 2025
Open
bors added a commit that referenced this pull request Nov 9, 2025
@bors
Auto merge of #148721 - Zalathar:rollup-398va3y, r=Zalathar
20f1c04 
Rollup of 22 pull requests

Successful merges:

 - #128666 (Add `overflow_checks` intrinsic)
 - #146305 (Add correct suggestion for multi-references for self type in method)
 - #147179 ([DebugInfo] Fix container types failing to find template args)
 - #147743 (Show packed field alignment in mir_transform_unaligned_packed_ref)
 - #148079 (Rename `downcast_[ref|mut]_unchecked` -> `downcast_unchecked_[ref|mut]`)
 - #148084 (Optimize path components iteration on platforms that don't have prefixes)
 - #148126 (Fix rust stdlib build failing for VxWorks)
 - #148204 (Modify contributor email entries in .mailmap)
 - #148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names)
 - #148333 (constify result unwrap unchecked)
 - #148539 (Add Allocator proxy impls for Box, Rc, and Arc)
 - #148601 (`invalid_atomic_ordering`: also lint `update` & `try_update`)
 - #148612 (Add note for identifier with attempted hygiene violation)
 - #148613 (Switch hexagon targets to rust-lld)
 - #148619 (Enable std locking functions on AIX)
 - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`)
 - #148649 (don't completely reset `HeadUsages`)
 - #148673 (Remove a remnant of `dyn*` from the parser)
 - #148675 (Remove eslint-js from npm dependencies)
 - #148680 (Recover `[T: N]` as `[T; N]`)
 - #148688 (Remove unused argument `features` from `eval_config_entry`)
 - #148711 (Use the current lint note id when parsing `cfg!()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@RalfJung RalfJung changed the title Enable std locking functions on AIX Enable std file locking functions on AIX Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Noratrieb Noratrieb

Labels

O-aix OS: Big Blue's Advanced Interactive eXecutive.. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@amy-kwan @rustbot @hkBst @Noratrieb @workingjubilee @bors @joboet