Rollup of 7 pull requests #148412

matthiaskrgr · 2025-11-02T19:21:05Z

Successful merges:

Constify Range functions #146573 (Constify Range functions)
Add is_ascii function optimized for LoongArch64 for [u8] #146699 (Add is_ascii function optimized for LoongArch64 for [u8])
std: don't leak the thread closure if destroying the thread attributes fails #148026 (std: don't leak the thread closure if destroying the thread attributes fails)
Ignore unix socket related tests for VxWorks #148135 (Ignore unix socket related tests for VxWorks)
clippy fixes and code simplification #148211 (clippy fixes and code simplification)
Generalize branch references #148395 (Generalize branch references)
Fix suggestion when there were a colon already in generics #148405 (Fix suggestion when there were a colon already in generics)

r? @ghost
@rustbot modify labels: rollup

Similar to x86_64, on LoongArch64 we use the `vmskltz.b` instruction to test the high bit in a lane. For longer input cases, the performance improvement is significant. For unaligned cases close to 32 bytes in length, there's some regression, but it seems acceptable. | core benches (MB/s) | Before | After | % | |--------------------------------------------------------|--------|--------|---------| | ascii::is_ascii::short::case00_libcore | 1000 | 1000 | 0.00 | | ascii::is_ascii::medium::case00_libcore | 8000 | 8000 | 0.00 | | ascii::is_ascii::long::case00_libcore | 183947 | 436875 | +137.50 | | ascii::is_ascii::unaligned_head_medium::case00_libcore | 7750 | 2818 | -63.64 | | ascii::is_ascii::unaligned_head_long::case00_libcore | 317681 | 436812 | +37.50 | | ascii::is_ascii::unaligned_tail_medium::case00_libcore | 7750 | 3444 | -55.56 | | ascii::is_ascii::unaligned_tail_long::case00_libcore | 155311 | 436812 | +181.25 | | ascii::is_ascii::unaligned_both_medium::case00_libcore | 7500 | 3333 | -55.56 | | ascii::is_ascii::unaligned_both_long::case00_libcore | 174700 | 436750 | +150.00 |

…s fails

Constify Range functions Constify various `Range` traits, functions, and implementations

…crum Add `is_ascii` function optimized for LoongArch64 for [u8] Similar to x86_64, on LoongArch64 we use the `vmskltz.b` instruction to test the high bit in a lane. For longer input cases, the performance improvement is significant. For unaligned cases close to 32 bytes in length, there's some regression, but it seems acceptable. | core benches (MB/s) | Before | After | % | |--------------------------------------------------------|--------|--------|---------| | ascii::is_ascii::short::case00_libcore | 1000 | 1000 | 0.00 | | ascii::is_ascii::medium::case00_libcore | 8000 | 8000 | 0.00 | | ascii::is_ascii::long::case00_libcore | 183947 | 436875 | +137.50 | | ascii::is_ascii::unaligned_head_medium::case00_libcore | 7750 | 2818 | -63.64 | | ascii::is_ascii::unaligned_head_long::case00_libcore | 317681 | 436812 | +37.50 | | ascii::is_ascii::unaligned_tail_medium::case00_libcore | 7750 | 3444 | -55.56 | | ascii::is_ascii::unaligned_tail_long::case00_libcore | 155311 | 436812 | +181.25 | | ascii::is_ascii::unaligned_both_medium::case00_libcore | 7500 | 3333 | -55.56 | | ascii::is_ascii::unaligned_both_long::case00_libcore | 174700 | 436750 | +150.00 |

…=Mark-Simulacrum std: don't leak the thread closure if destroying the thread attributes fails The comment about double-free is wrong – we can safely drop both the thread attributes and the thread closure. Here, I've used `DropGuard` for the attributes and moved the `Box::into_raw` to just before the `pthread_create`.

…k-Simulacrum Ignore unix socket related tests for VxWorks Unix Sockets are not implemented in VxWorks, and therefore, ignore testcases related to UnixDatagram, UnixListener and UnixStream.

clippy fixes and code simplification

…s, r=marcoieni Generalize branch references It should be safe to merge this before the rename, and I'd like to do that, so we can test if beta/stable PRs work. r? ``@marcoieni``

…uwer Fix suggestion when there were a colon already in generics Finally found time to fix rust-lang#144215 I don't feel like this `colon_flag` is perfect solution and that it can be refactored, but I'd say that this is pretty good as it, I was tried to refactor this a little, but the thing is the scope where `param.colon_span` lives is very limited, so there is not much time to check was there colon or not, I tried to rewrite this into more functional style to address this, but it becomes way more unreadable than this one or even less performant, maybe some comments could push readability of this fix further, maybe a comment for enum or `colon_flag`?

matthiaskrgr · 2025-11-02T19:43:55Z

@bors r+ rollup=never p=5

bors · 2025-11-02T19:43:58Z

📌 Commit 285cb31 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-11-02T23:12:29Z

⌛ Testing commit 285cb31 with merge c5dabe8...

bors · 2025-11-03T02:50:52Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c5dabe8 to master...

rust-timer · 2025-11-03T02:53:01Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146573	Constify Range functions	`867b37fe44b76c1dcc46c1f92aa7ab8c52f2a201` (link)
#146699	Add `is_ascii` function optimized for LoongArch64 for [u8]	`27c8f9dc7fde095f35d9416c33bd895f3d61fc5b` (link)
#148026	std: don't leak the thread closure if destroying the thread…	`56d8b4b7eda0c88707b793e9a444b8b2f78d5745` (link)
#148135	Ignore unix socket related tests for VxWorks	`1e306ba7505c2c36a2f94557e8c143aaef75cd4b` (link)
#148211	clippy fixes and code simplification	`54fad124cc562260db5b046547985b50e80c543e` (link)
#148395	Generalize branch references	`d3bc96d573f076934c00c391c2133db30a55e769` (link)
#148405	Fix suggestion when there were a colon already in generics	`2a94a7ee50947c087c5c94caac0dfb4d152f3099` (link)

previous master: b15a874aaf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-03T02:53:50Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b15a874 (parent) -> c5dabe8 (this PR)

Test differences

Show 272 test diffs

Stage 1

[ui] tests/ui/generics/missing-param-but-has-colon-144215.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/generics/missing-param-but-has-colon-144215.rs: [missing] -> pass (J1)

Additionally, 270 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c5dabe8cf798123087d094f06417f5a767ca73e8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 7214.7s -> 5622.9s (-22.1%)
aarch64-apple: 7237.0s -> 8829.7s (+22.0%)
pr-check-2: 2314.3s -> 2735.1s (+18.2%)
dist-x86_64-windows-gnullvm: 4587.0s -> 5308.3s (+15.7%)
x86_64-rust-for-linux: 2692.7s -> 3111.9s (+15.6%)
x86_64-gnu-debug: 6265.6s -> 7212.2s (+15.1%)
dist-aarch64-msvc: 6138.5s -> 5271.4s (-14.1%)
x86_64-msvc-ext2: 5457.0s -> 6171.5s (+13.1%)
test-various: 6072.6s -> 6862.2s (+13.0%)
x86_64-gnu-gcc: 3099.9s -> 3501.7s (+13.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-03T04:00:58Z

Finished benchmarking commit (c5dabe8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.9%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Binary size

Results (primary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-1.1%, 0.0%]	2

Bootstrap: 473.039s -> 474.179s (0.24%)
Artifact size: 390.80 MiB -> 390.90 MiB (0.03%)

heiher and others added 15 commits September 18, 2025 10:13

Constify Range functions

4ee19d9

std: don't leak the thread closure if destroying the thread attribute…

a7f08de

…s fails

Ignore unix socket related tests on VxWorks

ff13880

clippy fixes and code simplification

9e4ec2a

Generalize branch references to HEAD

d3473f0

Generalize branch name in scripts

ae830ef

add enum to address lifetime with colon problem

4e17091

Rollup merge of rust-lang#146573 - Randl:const-range, r=Mark-Simulacrum

6621bbc

Constify Range functions Constify various `Range` traits, functions, and implementations

Rollup merge of rust-lang#148135 - hax0kartik:fix-vx-unix-sock, r=Mar…

0a9018b

…k-Simulacrum Ignore unix socket related tests for VxWorks Unix Sockets are not implemented in VxWorks, and therefore, ignore testcases related to UnixDatagram, UnixListener and UnixStream.

Rollup merge of rust-lang#148211 - hkBst:clippy-fix-13, r=nnethercote

49692e1

clippy fixes and code simplification

Rollup merge of rust-lang#148395 - Kobzol:generalize-branch-reference…

7ed1f93

…s, r=marcoieni Generalize branch references It should be safe to merge this before the rename, and I'd like to do that, so we can test if beta/stable PRs work. r? ``@marcoieni``

rustbot added the rollup A PR which is a rollup label Nov 2, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2025

Zalathar mentioned this pull request Nov 3, 2025

Rollup of 5 pull requests #148420

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2025

bors merged commit c5dabe8 into rust-lang:master Nov 3, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 3, 2025

bors mentioned this pull request Nov 3, 2025

Port all viable contracts from verify-rust-std #147148

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #148412

Rollup of 7 pull requests #148412

Uh oh!

matthiaskrgr commented Nov 2, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Rollup of 7 pull requests #148412

Rollup of 7 pull requests #148412

Uh oh!

Conversation

matthiaskrgr commented Nov 2, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 3, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

matthiaskrgr commented Nov 2, 2025 •

edited by rustbot

Loading