Skip to content

Conversation

@LorrensP-2158466
Copy link
Contributor

@LorrensP-2158466 LorrensP-2158466 commented Oct 31, 2025

Fixes #148289
Fixes case 1 of #104477 (it's the same as #148289)
Should unblock #148187

Instead of propagating every fr-: shorter_fr+ we find, only propagate those that matter to the closure in question. This could otherwise cause valid code to be rejected.

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 31, 2025
@LorrensP-2158466 LorrensP-2158466 changed the title Do not propogate unnecessary closure constraints + tests. Do not propogate unnecessary closure constraints. Oct 31, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot

This comment has been minimized.

@LorrensP-2158466
Copy link
Contributor Author

LorrensP-2158466 commented Oct 31, 2025

Excuse me ehuss for the automatic ping, I was a bit too fast with pushing the typo fixes reported by the tidy job.

@lcnr
Copy link
Contributor

lcnr commented Nov 3, 2025

@bors try @rust-timer

let's do a crater run, even if I think it should be fine. Then I/we need to write an FCP proposal 😁

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 3, 2025
Do not propogate unnecessary closure constraints.
@LorrensP-2158466
Copy link
Contributor Author

let's do a crater run, even if I think it should be fine. Then I/we need to write an FCP proposal 😁

Alright!

@LorrensP-2158466
Copy link
Contributor Author

Then I/we need to write an FCP proposal 😁

BTW, I would love to help with this if isn't to much to ask. I have never done it, so I might as well get some experience. :)

@rust-bors
Copy link

rust-bors bot commented Nov 3, 2025

☀️ Try build successful (CI)
Build commit: f27166d (f27166d4c64dc29edc5ea3214357f191edf8b635, parent: f5711a55f5d5e2f942057d0f6d648dd2d8b2c37b)

@rust-timer

This comment has been minimized.

@lcnr
Copy link
Contributor

lcnr commented Nov 4, 2025

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-148329 created and queued.
🤖 Automatically detected try build f27166d
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
@Kobzol
Copy link
Member

Kobzol commented Nov 4, 2025

@rust-timer build f27166d

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f27166d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.7% [-5.4%, -4.0%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.205s -> 473.796s (-0.09%)
Artifact size: 390.90 MiB -> 390.90 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unnecessary closure constraint propagation

7 participants