-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Do not propogate unnecessary closure constraints. #148329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
440270a to
b1299ee
Compare
|
Some changes occurred in src/tools/cargo cc @ehuss |
This comment has been minimized.
This comment has been minimized.
b1299ee to
8c66aab
Compare
|
Excuse me |
1e89617 to
a36dc08
Compare
|
@bors try @rust-timer let's do a crater run, even if I think it should be fine. Then I/we need to write an FCP proposal 😁 |
This comment has been minimized.
This comment has been minimized.
Do not propogate unnecessary closure constraints.
Alright! |
BTW, I would love to help with this if isn't to much to ask. I have never done it, so I might as well get some experience. :) |
This comment has been minimized.
This comment has been minimized.
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
@rust-timer build f27166d |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f27166d): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -4.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.205s -> 473.796s (-0.09%) |
Fixes #148289
Fixes case 1 of #104477 (it's the same as #148289)
Should unblock #148187
Instead of propagating every
fr-: shorter_fr+we find, only propagate those that matter to the closure in question. This could otherwise cause valid code to be rejected.r? @lcnr