Skip to content

Fix typos: duplicate words in comments #148175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Fix typos: duplicate words in comments #148175

merged 1 commit into from
Oct 28, 2025

Conversation

@osamakader
Copy link
Contributor

  • Fix 'the the' → 'the' in rustc_const_eval
  • Fix 'wether' → 'whether' in compiletest
  • Fix 'is is' → 'is' in rustc_ast_pretty (2 instances)

@osamakader
Fix typos: duplicate words in comments
bf6f303 
- Fix 'the the' → 'the' in rustc_const_eval
- Fix 'wether' → 'whether' in compiletest
- Fix 'is is' → 'is' in rustc_ast_pretty (2 instances)

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lcnr
Copy link
Contributor

lcnr commented Oct 27, 2025

r? lcnr
@bors r+ rollup

You've also opened #148155 recently. While this PR does feel useful enough to get merged, I do think internal typo and wording fixes are also not the best use of your time.

While it's hard to find good issues while still getting started to contribute to the project, there's hopefully something useful for you in https://rustc-dev-guide.rust-lang.org/#what-should-i-work-on

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit bf6f303 has been approved by lcnr

It is now in the queue for this repository.

@rustbot rustbot assigned lcnr and unassigned nnethercote Oct 27, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2025
@matthiaskrgr
Rollup merge of rust-lang#148175 - osamakader:fix-typos-duplicate-wor…
c315850 
…ds, r=lcnr

Fix typos: duplicate words in comments

- Fix 'the the' → 'the' in rustc_const_eval
- Fix 'wether' → 'whether' in compiletest
- Fix 'is is' → 'is' in rustc_ast_pretty (2 instances)
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2025
Open
@osamakader
Copy link
Contributor Author

r? lcnr

@bors r+ rollup

You've also opened #148155 recently. While this PR does feel useful enough to get merged, I do think internal typo and wording fixes are also not the best use of your time.

While it's hard to find good issues while still getting started to contribute to the project, there's hopefully something useful for you in https://rustc-dev-guide.rust-lang.org/#what-should-i-work-on

Yes it took me long time actually to find it and I definitely like to do real fix or improvement. Issues with E-easy are actually not that simple, I will check that out and hopefully find potential one soon, thanks.

bors added a commit that referenced this pull request Oct 28, 2025
@bors
Auto merge of #148178 - matthiaskrgr:rollup-yy0swwt, r=matthiaskrgr
c829707 
Rollup of 6 pull requests

Successful merges:

 - #147840 (Rework unsizing coercions in the new solver)
 - #148139 (Add `coverage` scope for controlling paths in code coverage)
 - #148154 (Add a mailmap entry)
 - #148158 (ci: loongarch64: use medium code model to avoid relocation overflows)
 - #148172 (rustc-dev-guide subtree update)
 - #148175 (Fix typos: duplicate words in comments)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 28, 2025
@Zalathar
Rollup merge of rust-lang#148175 - osamakader:fix-typos-duplicate-wor…
a4230a0 
…ds, r=lcnr

Fix typos: duplicate words in comments

- Fix 'the the' → 'the' in rustc_const_eval
- Fix 'wether' → 'whether' in compiletest
- Fix 'is is' → 'is' in rustc_ast_pretty (2 instances)
This was referenced Oct 28, 2025
Closed
Merged
bors added a commit that referenced this pull request Oct 28, 2025
@bors
Auto merge of #148202 - Zalathar:rollup-2eriuc3, r=Zalathar
c9537a9 
Rollup of 14 pull requests

Successful merges:

 - #144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce)
 - #147185 (repr(transparent): do not consider repr(C) types to be 1-ZST)
 - #147840 (Rework unsizing coercions in the new solver)
 - #147915 (Update target maintainers android.md)
 - #148013 (1.91.0 release notes)
 - #148044 (compiletest: show output in debug logging)
 - #148057 (tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack)
 - #148139 (Add `coverage` scope for controlling paths in code coverage)
 - #148154 (Add a mailmap entry)
 - #148158 (ci: loongarch64: use medium code model to avoid relocation overflows)
 - #148166 (Re-enable macro-stepping test for AArch64)
 - #148172 (rustc-dev-guide subtree update)
 - #148175 (Fix typos: duplicate words in comments)
 - #148186 (rustdoc-search: add an integration test for CCI)

Failed merges:

 - #147935 (Add LLVM realtime sanitizer)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ff7909b into rust-lang:master Oct 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 28, 2025
rust-timer added a commit that referenced this pull request Oct 28, 2025
@rust-timer
Unrolled build for #148175
c2ae3b1 
Rollup merge of #148175 - osamakader:fix-typos-duplicate-words, r=lcnr

Fix typos: duplicate words in comments

- Fix 'the the' → 'the' in rustc_const_eval
- Fix 'wether' → 'whether' in compiletest
- Fix 'is is' → 'is' in rustc_ast_pretty (2 instances)
bors added a commit that referenced this pull request Oct 28, 2025
@bors
Auto merge of #148178 - matthiaskrgr:rollup-yy0swwt, r=matthiaskrgr
e964b00 
Rollup of 6 pull requests

Successful merges:

 - #147840 (Rework unsizing coercions in the new solver)
 - #148139 (Add `coverage` scope for controlling paths in code coverage)
 - #148154 (Add a mailmap entry)
 - #148158 (ci: loongarch64: use medium code model to avoid relocation overflows)
 - #148172 (rustc-dev-guide subtree update)
 - #148175 (Fix typos: duplicate words in comments)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

5 participants

@osamakader @rustbot @lcnr @bors @nnethercote