Rollup of 4 pull requests #148012

Zalathar · 2025-10-23T01:06:33Z

Successful merges:

Add new inherit_handles flag to CommandExt trait #115501 (Add new inherit_handles flag to CommandExt trait)
std: reorganize the UNIX-internal weak module #146629 (std: reorganize the UNIX-internal weak module)
feat(rustdoc): --emit=depinfo output to stdout via - #147762 (feat(rustdoc): --emit=depinfo output to stdout via -)
fix: Don't add diff symbol to unchanged lines #148001 (fix: Don't add diff symbol to unchanged lines)

r? @ghost
@rustbot modify labels: rollup

This commit demonstrates that `rustdoc --emit=depinfo=-` hasn't yet supported emitting to stdout.

rustdoc's `--emit=depinfo` flag now supports using `-` to write the output to stdout.

This patch adds a new flag to the [`CommandExt`](1) trait to set whether to inherit the handles of the calling process (2) on Windows systems. ACP: rust-lang/libs-team#264 [1]: https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html [2]: https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessw

…les, r=ChrisDenton Add new inherit_handles flag to CommandExt trait This PR adds a new flag to the [`CommandExt`](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html) trait to set whether to inherit the handles of the calling process ([ref][1]). This is necessary when, for example, spawning a process with a `pseudoconsole` attached. r? ``@ChrisDenton`` ACP: rust-lang/libs-team#264 [1]: <https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessw>

std: reorganize the UNIX-internal `weak` module This moves the `dlsym`-based and weak-linkage versions of the `weak!` macro into separate files, both of which include a common test file. As a result, both versions will be tested on all the platforms where they are used. Since the `#[link_name]` arm of the `dlsym` version was unused, I've removed it. I've also removed the unused `raw_syscall!` and non-Linux `syscall!` macros and gated the `#[allow(dead_code, unused_macros)]` to only apply on non-Linux platforms, so compilation will fail if `weak` turns out to be unused on all platforms. The last change concerns the use of `dlsym!` on FreeBSD: it is only used once, to link against `sysctlbyname`. But that symbol is always available, so there is no need for weak linkage.

…r=fmease feat(rustdoc): `--emit=depinfo` output to stdout via `-` rustdoc's `--emit=depinfo` flag now supports using `-` to write the output to stdout, aligning with rustc's behavior. This will fix <rust-lang#147649>. ### How to review * The first commit demonstrates that `rustdoc --emit=depinfo=-` hasn't yet supported emitting to stdout. * The second implements it and the diff shows how the behavior changes.

…-lines, r=fmease fix: Don't add diff symbol to unchanged lines When rendering a "multi-line" suggestion with the [`Diff`](https://github.com/rust-lang/rust/blob/dc1feabef242259d61bd930713de3250577c1c71/compiler/rustc_errors/src/emitter.rs#L3078) format, `rustc` uses a [diff symbol](https://github.com/rust-lang/rust/blob/dc1feabef242259d61bd930713de3250577c1c71/compiler/rustc_errors/src/emitter.rs#L3017-L3022) for [any line that has a highlight part](https://github.com/rust-lang/rust/blob/dc1feabef242259d61bd930713de3250577c1c71/compiler/rustc_errors/src/emitter.rs#L2705-L2713). This includes highlight parts that are highlighting nothing, i.e., a span of `0..0`. This leads `rustc` to add a diff symbol unnecessarily to lines that have no changes and are not highlighted. This PR makes it so that `rustc` will not add a diff symbol to lines that contain no changes/highlights. Note: This PR is part of my ongoing effort to have `rustc` use `annotate-snippets` for rendering. This change will make it so that `rustc` and `annotate-snippets` will match in this case.

Zalathar · 2025-10-23T01:06:52Z

@bors r+ rollup=never p=5

bors · 2025-10-23T01:06:54Z

📌 Commit 2f7e07b has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-23T02:01:39Z

⌛ Testing commit 2f7e07b with merge 7838ce1...

bors · 2025-10-23T05:08:13Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 7838ce1 to master...

rust-timer · 2025-10-23T05:09:25Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#115501	Add new inherit_handles flag to CommandExt trait	`37781bdb3cb3be195cfedcdead35562933f507e7` (link)
#146629	std: reorganize the UNIX-internal `weak` module	`2b9cfdab9875b46e38ae065eb9c1d0e0c43cf8dd` (link)
#147762	feat(rustdoc): `--emit=depinfo` output to stdout via `-`	`3c848ad578d9ea2605ea3e5ac6f2f2ba8a3164b1` (link)
#148001	fix: Don't add diff symbol to unchanged lines	`e65e6e47bc088ddd4c489ac23180d561abf3ee4a` (link)

previous master: 6244effd03

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-23T05:11:10Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6244eff (parent) -> 7838ce1 (this PR)

Test differences

Show 17 test diffs

Stage 1

sys::pal::unix::weak::dlsym::tests::weak_existing: [missing] -> pass (J3)
sys::pal::unix::weak::dlsym::tests::weak_missing: [missing] -> pass (J3)
sys::pal::unix::weak::tests::dlsym_existing: pass -> [missing] (J3)
sys::pal::unix::weak::tests::dlsym_missing: pass -> [missing] (J3)
sys::pal::unix::weak::weak_linkage::tests::weak_existing: [missing] -> pass (J3)
sys::pal::unix::weak::weak_linkage::tests::weak_missing: [missing] -> pass (J3)
[ui] tests/ui/process/win-inherit-handles.rs: [missing] -> ignore (only executed when the operating system is windows) (J5)

Stage 2

sys::pal::unix::weak::dlsym::tests::weak_existing: [missing] -> pass (J0)
sys::pal::unix::weak::dlsym::tests::weak_missing: [missing] -> pass (J0)
sys::pal::unix::weak::tests::dlsym_existing: pass -> [missing] (J0)
sys::pal::unix::weak::tests::dlsym_missing: pass -> [missing] (J0)
[ui] tests/ui/process/win-inherit-handles.rs: [missing] -> pass (J1)
[ui] tests/ui/process/win-inherit-handles.rs: [missing] -> ignore (only executed when the operating system is windows) (J2)
sys::pal::unix::weak::weak_linkage::tests::weak_existing: [missing] -> pass (J4)
sys::pal::unix::weak::weak_linkage::tests::weak_missing: [missing] -> pass (J4)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7838ce1a3a0046d02c8a0d30d54465c39cceb8de --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-msvc: 5409.1s -> 6539.9s (20.9%)
pr-check-1: 1519.5s -> 1817.1s (19.6%)
dist-x86_64-apple: 6082.3s -> 7185.0s (18.1%)
x86_64-rust-for-linux: 2609.3s -> 3008.0s (15.3%)
aarch64-gnu-llvm-20-1: 3372.3s -> 3883.3s (15.2%)
i686-gnu-nopt-1: 7114.9s -> 8138.2s (14.4%)
aarch64-apple: 7508.3s -> 8512.0s (13.4%)
aarch64-gnu-llvm-20-2: 2280.7s -> 2569.1s (12.6%)
dist-various-1: 4164.7s -> 3733.9s (-10.3%)
i686-gnu-2: 5364.1s -> 5904.9s (10.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-23T06:19:09Z

Finished benchmarking commit (7838ce1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -7.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.9%	[-7.9%, -7.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.983s -> 473.667s (0.36%)
Artifact size: 390.70 MiB -> 390.66 MiB (-0.01%)

joboet and others added 9 commits October 14, 2025 13:36

std: reorganize the UNIX-internal weak module

e043a0b

test(rustdoc): depinfo cannot be emitted to stdout

0abea28

This commit demonstrates that `rustdoc --emit=depinfo=-` hasn't yet supported emitting to stdout.

feat(rustdoc): --emit=depinfo output to stdout via -

e7130d3

rustdoc's `--emit=depinfo` flag now supports using `-` to write the output to stdout.

fix: Don't add diff symbol to unchanged lines

c7f014d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025

bors merged commit 7838ce1 into rust-lang:master Oct 23, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 23, 2025

Zalathar deleted the rollup-ed6cnn8 branch October 23, 2025 05:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 4 pull requests #148012

Rollup of 4 pull requests #148012

Uh oh!

Zalathar commented Oct 23, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Rollup of 4 pull requests #148012

Rollup of 4 pull requests #148012

Uh oh!

Conversation

Zalathar commented Oct 23, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 23, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Zalathar commented Oct 23, 2025 •

edited by rustbot

Loading