cmse: improve error messages #147479
Merged
cmse: improve error messages #147479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the span of the types that don't fit, rather than the span of the whole signature.
folkertdev
added
F-cmse_nonsecure_entry
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
davidtwco
approved these changes
Oct 9, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 9, 2025
… r=davidtwco cmse: improve error messages tracking issue: rust-lang#81391 tracking issue: rust-lang#75835 Improves the cmse error messages (e.g. by using more accurate spans), and attempts to clean up the control flow a bit. This is partially in preparation for one final addition: warnings when `union` types or types with niches cross the security boundary. That will be a folllow-up. Meant to be reviewed commit-by-commit r? `@davidtwco`
bors
added a commit
that referenced
this pull request
Oct 9, 2025
Rollup of 4 pull requests Successful merges: - #147447 (Set the minimum deployment target for `aarch64-apple-watchos`) - #147479 (cmse: improve error messages) - #147515 (Update rustc-perf submodule) - #147523 (x86_64-bigint-helpers test: update test assertion to cover registers r8 and r9) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 10, 2025
Rollup merge of #147479 - folkertdev:cmse-refactor-warnings, r=davidtwco cmse: improve error messages tracking issue: #81391 tracking issue: #75835 Improves the cmse error messages (e.g. by using more accurate spans), and attempts to clean up the control flow a bit. This is partially in preparation for one final addition: warnings when `union` types or types with niches cross the security boundary. That will be a folllow-up. Meant to be reviewed commit-by-commit r? ``@davidtwco``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #81391
tracking issue: #75835
Improves the cmse error messages (e.g. by using more accurate spans), and attempts to clean up the control flow a bit. This is partially in preparation for one final addition: warnings when
uniontypes or types with niches cross the security boundary. That will be a folllow-up.Meant to be reviewed commit-by-commit
r? @davidtwco