Skip to content

Implement fs api set_times and set_times_nofollow #147468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Implement fs api set_times and set_times_nofollow #147468

wants to merge 14 commits into from
+561 −52

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 8, 2025 •
edited by rustbot
Loading

implementation of #147455

r? @joshtriplett

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang marked this pull request as draft October 8, 2025 09:12
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@chenyukang chenyukang force-pushed the yukang-api-set-times branch from f1ab883 to 1440cfb Compare October 8, 2025 09:59
@chenyukang
Copy link
Member Author

i'm following this PR: https://github.com/rust-lang/rust/pull/142938/files
somehow surprised we don't need to add unit test for a new api?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-api-set-times branch 8 times, most recently from c135e31 to 20f1468 Compare October 8, 2025 16:25
@chenyukang chenyukang marked this pull request as ready for review October 8, 2025 17:28
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2025
joshtriplett
joshtriplett reviewed Oct 9, 2025
View reviewed changes
joshtriplett
joshtriplett reviewed Oct 9, 2025
View reviewed changes
joshtriplett
joshtriplett reviewed Oct 9, 2025
View reviewed changes
joshtriplett
joshtriplett reviewed Oct 9, 2025
View reviewed changes
joshtriplett
joshtriplett reviewed Oct 9, 2025
View reviewed changes
joshtriplett
joshtriplett reviewed Oct 9, 2025
View reviewed changes
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 13, 2025
@rust-bors
Auto merge of #147468 - chenyukang:yukang-api-set-times, r=<try>
af03d44 
Implement fs api set_times and set_times_nofollow

try-job: aarch64-gnu-debug
@chenyukang
Copy link
Member Author

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Oct 13, 2025

Try build cancelled. Cancelled workflows:

@chenyukang
Copy link
Member Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 13, 2025
@rust-bors
Auto merge of #147468 - chenyukang:yukang-api-set-times, r=<try>
3f6a1a5 
Implement fs api set_times and set_times_nofollow
@rust-bors
Copy link

rust-bors bot commented Oct 13, 2025

☀️ Try build successful (CI)
Build commit: 3f6a1a5 (3f6a1a51f7877a7fc3b7b3ff1763eef08d683c48, parent: ed1d94311e7ed53eabb5667ef577802d88d1aaee)

@chenyukang
Copy link
Member Author

@bors try jobs=homu

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 14, 2025
@rust-bors
Auto merge of #147468 - chenyukang:yukang-api-set-times, r=<try>
6706c6f 
Implement fs api set_times and set_times_nofollow

try-job: homu
@rust-bors
Copy link

rust-bors bot commented Oct 14, 2025

💔 Test for 6706c6f failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang
Copy link
Member Author

@bors r=joshtriplett

@bors
Copy link
Collaborator

bors commented Oct 14, 2025

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Oct 14, 2025

📌 Commit d2f590a has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
chenyukang added a commit to chenyukang/rust that referenced this pull request Oct 14, 2025
@chenyukang
Rollup merge of rust-lang#147468 - chenyukang:yukang-api-set-times, r…
35e64c4 
…=joshtriplett

Implement fs api set_times and set_times_nofollow

implementation of rust-lang#147455

r? `@joshtriplett`
@chenyukang chenyukang mentioned this pull request Oct 14, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147468 - chenyukang:yukang-api-set-times, r…
f018622 
…=joshtriplett

Implement fs api set_times and set_times_nofollow

implementation of rust-lang#147455

r? ``@joshtriplett``
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147468 - chenyukang:yukang-api-set-times, r…
0adccf9 
…=joshtriplett

Implement fs api set_times and set_times_nofollow

implementation of rust-lang#147455

r? ```@joshtriplett```
@Zalathar Zalathar mentioned this pull request Oct 14, 2025
Closed
bors added a commit that referenced this pull request Oct 14, 2025
@bors
Auto merge of #147659 - Zalathar:rollup-1rdmknm, r=Zalathar
26a1e5f 
Rollup of 11 pull requests

Successful merges:

 - #146277 (Enable `u64` limbs in `core::num::bignum`)
 - #146976 (constify basic Clone impls)
 - #147249 (Do two passes of `handle_opaque_type_uses_next`)
 - #147266 (fix 2 search graph bugs)
 - #147468 (Implement fs api set_times and set_times_nofollow)
 - #147497 (`proc_macro` cleanups (3/N))
 - #147594 (std: implement `pal::os::exit` for VEXos)
 - #147596 (Adjust the Arm targets in CI to reflect latest changes)
 - #147607 (GVN: Invalidate derefs at loop headers)
 - #147620 (Avoid redundant UB check in RangeFrom slice indexing)
 - #147647 (Hide vendoring and copyright in GHA group)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar
Copy link
Contributor

Failed in rollup in dist-various-1: #147659 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2025
@joshtriplett
Copy link
Member

@chenyukang If I'm reading the failure correctly, I think libc::AT_SYMLINK_NOFOLLOW doesn't exist on redox. set_times_nofollow is using it unconditionally on all unix platforms, but it won't exist on some of them.

I think the right fix for that is to pass a follow_symlinks: bool to the internal helper function, and then have the target-specific cfg branches translate that into the appropriate flag for their platform. That would also avoid the logic in the apple case that translates to the correct flag for apple.

@chenyukang
Copy link
Member Author

@chenyukang If I'm reading the failure correctly, I think libc::AT_SYMLINK_NOFOLLOW doesn't exist on redox. set_times_nofollow is using it unconditionally on all unix platforms, but it won't exist on some of them.

I think the right fix for that is to pass a follow_symlinks: bool to the internal helper function, and then have the target-specific cfg branches translate that into the appropriate flag for their platform. That would also avoid the logic in the apple case that translates to the correct flag for apple.

good idea, I updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

+2 more reviewers

@sardok sardok sardok left review comments

@juntyr juntyr juntyr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joshtriplett joshtriplett

Labels

O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@chenyukang @rustbot @rust-log-analyzer @joshtriplett @bors @Zalathar @sardok @juntyr