Skip to content

some more proc_macro cleanups #147386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

some more proc_macro cleanups #147386

merged 3 commits into from
Oct 8, 2025

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Oct 5, 2025 •
edited by rustbot
Loading

Several smaller cleanups to proc_macro. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.

Followup to #147166.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@petrochenkov
Copy link
Contributor

The second commit makes sense to me, the arena's use is limited, and if the &mut self doesn't cause any inconvenience, then it's better to use it, because it's simpler.

petrochenkov
petrochenkov reviewed Oct 6, 2025
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 6, 2025
@cyrgani cyrgani force-pushed the proc-macro-cleanup-2 branch from df4d26e to 7aa52ea Compare October 7, 2025 19:21
@cyrgani cyrgani added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2025
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit 7aa52ea has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 8, 2025
Merged
bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of #147475 - matthiaskrgr:rollup-iyrkv0g, r=matthiaskrgr
7a52736 
Rollup of 6 pull requests

Successful merges:

 - #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error))
 - #147386 (some more `proc_macro` cleanups)
 - #147412 (Convert impossible cases in macro resolution into assertions)
 - #147464 (prefer repeat_n() over repeat().take())
 - #147469 (Add rustdoc crate name in error)
 - #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5c13022 into rust-lang:master Oct 8, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 8, 2025
rust-timer added a commit that referenced this pull request Oct 8, 2025
@rust-timer
Unrolled build for #147386
5f946f3 
Rollup merge of #147386 - cyrgani:proc-macro-cleanup-2, r=petrochenkov

some more `proc_macro` cleanups

Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.

Followup to #147166.
@cyrgani cyrgani deleted the proc-macro-cleanup-2 branch October 8, 2025 19:27
@cyrgani cyrgani mentioned this pull request Oct 8, 2025
Merged
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#147386 - cyrgani:proc-macro-cleanup-2, r=pe…
7e44c2b 
…trochenkov

some more `proc_macro` cleanups

Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.

Followup to rust-lang#147166.
chenyukang added a commit to chenyukang/rust that referenced this pull request Oct 14, 2025
@chenyukang
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
8c04cf0 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
9bab601 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
ebbb223 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
3ee0174 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
df59997 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
428be2f 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
0cec036 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
rust-timer added a commit that referenced this pull request Oct 14, 2025
@rust-timer
Unrolled build for #147497
b83bae4 
Rollup merge of #147497 - cyrgani:proc-macro-cleanups-3, r=petrochenkov

`proc_macro` cleanups (3/N)

Followup to #147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
@bvanjoi bvanjoi mentioned this pull request Oct 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cyrgani @rustbot @petrochenkov @bors