Skip to content

Do not use dlltool to create DLL Import Libraries for Windows #147274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not use dlltool to create DLL Import Libraries for Windows #147274

wants to merge 1 commit into from
+53 −227

Conversation

@jfgoog
Copy link
Contributor

@jfgoog jfgoog commented Oct 2, 2025

Motivation and context: #147229

@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bjorn3
bjorn3 requested changes Oct 3, 2025
View reviewed changes
Copy link
Member

@bjorn3 bjorn3 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, this will break support for binutils < 2.40.

View changes since this review

compiler/rustc_session/src/options.rs
default_linker_libraries: bool = (false, parse_bool, [UNTRACKED],
"allow the linker to link its default libraries (default: no)"),
dlltool: Option<PathBuf> = (None, parse_opt_pathbuf, [UNTRACKED],
"import library generation tool (ignored except when targeting windows-gnu)"),
Copy link
Member

@bjorn3 bjorn3 Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stable option, so it can't be removed, only deprecated and ignored.

@jfgoog
Copy link
Contributor Author

jfgoog commented Oct 3, 2025

As I understand it, this will break support for binutils < 2.40.

Yes. This change was suggested in the discussion on the bug report, but landing is uncertain and complicated. I wanted to send a change anyway as a concrete point of discussion.

@davidtwco
Copy link
Member

davidtwco commented Oct 6, 2025

r? @wesleywiser

@rustbot rustbot assigned wesleywiser and unassigned davidtwco Oct 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2025

wesleywiser is currently at their maximum review capacity.
They may take a while to respond.

@petrochenkov petrochenkov mentioned this pull request Oct 6, 2025
Open
@bors
Copy link
Collaborator

bors commented Nov 5, 2025

☔ The latest upstream changes (presumably #147645) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 requested changes

Assignees

@wesleywiser wesleywiser

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jfgoog @rustbot @davidtwco @bors @bjorn3 @wesleywiser