Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #117276.
The current organisation of the
kernel_copy
mechanism used to specialiseio::copy
on Linux necessitated circular links between theio::copy
module and the implementation insys::pal::unix::kernel_copy
, as well as presenting an exception to the tidy PAL rule that forbids OS-based#[cfg]
s outside ofsys
andos
.This PR fixes this by moving
kernel_copy
tosys
(as per #117276) and returning aCopyState
from that function specifying whetherio::copy
should use its fallback. Thekernel_copy
function on other platforms just unconditionally returnsCopyState::Fallback
.