Skip to content

Ignore more failing ui tests for GCC backend #147058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

Ignore more failing ui tests for GCC backend #147058

merged 1 commit into from
Sep 27, 2025
+440 −297

Conversation

GuillaumeGomez
Copy link
Member

Needed for #146414.

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2025

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Sep 26, 2025
@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2025
Kobzol
Kobzol reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool to have a way of ignoring "ignore-backends", so that we can run these tests using the GCC backend in the future and quickly see which one of them still fail.

View changes since this review

tests/ui/cfg/assume-incomplete-release/assume-incomplete.rs
//@ proc-macro: ver-cfg-rel.rs
//@ revisions: assume no_assume
//@ [assume]compile-flags: -Z assume-incomplete-release
//@ ignore-backends: gcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are multiple revisions, we just copy-paste the same @ignore-backends line N times? That seems weird, huh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, my script just went wrong. Gonna send a fix, good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I genuinely thought that it was too specific to be an accident xD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no. ^^'

Don't confuse my incompetence with weird test setting. 😆

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

It would be cool to have a way of ignoring "ignore-backends", so that we can run these tests using the GCC backend in the future and quickly see which one of them still fail.

View changes since this review

I can add a new option for that if you want? :)

@Kobzol
Copy link
Member

Kobzol commented Sep 26, 2025

I meant it as a possible future improvement, definitely not a blocker for this PR. You can r=me once CI is green.

@GuillaumeGomez
Copy link
Member Author

Opening an issue for the new option then.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikic
Copy link
Contributor

nikic commented Sep 26, 2025

Are there any commonalities here that would avoid annotating so many tests? Just looking at the diffs, can we disable needs-unwind and proc-macro tests with codegen_gcc? Or does only some subset of those have to be disabled?

Generally I'd expect ignores like this to include a comment on why we're ignoring that test. For some of these it's pretty clear, but for others its not. The distinction between "we're ignoring this for now because of a codegen_gcc bug" and "we're ignoring this because codegen_gcc doesn't implement this feature" and "we're ignoring this because this is testing LLVM-specific behavior" is important.

@GuillaumeGomez
Copy link
Member Author

At this point it's hard to say. What I'm trying to achieve here is to run the tests that we know are supported by the GCC backend first so we solve our immediate issues with the GCC/rustc syncs. Then from there we can go through the ignored tests for GCC to check if it's a bug or simply something specific to LLVM.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 26, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez
Copy link
Member Author

@bors r=Kobzol rollup

@bors
Copy link
Collaborator

bors commented Sep 26, 2025

📌 Commit a535c7b has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#147058 - GuillaumeGomez:ignore-more-ui-test…
69a3cac 
…s, r=Kobzol

Ignore more failing ui tests for GCC backend

Needed for rust-lang#146414.

r? `@Kobzol`
This was referenced Sep 26, 2025
Closed
Merged
bors added a commit that referenced this pull request Sep 26, 2025
@bors
Auto merge of #147074 - matthiaskrgr:rollup-sm3owsd, r=matthiaskrgr
ec37393 
Rollup of 10 pull requests

Successful merges:

 - #145113 (resolve: Do not finalize shadowed bindings)
 - #146523 (Demote both armebv7r-none-* targets.)
 - #146704 (port `#[debugger_visualizer]` to the new attribute system)
 - #146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu)
 - #146778 (Use standard attribute logic for allocator shim)
 - #146849 (Reduce some uses of `LegacyBang`)
 - #147016 (fix doc comments to be more standard)
 - #147027 (Add new `tyalias` intra-doc link disambiguator)
 - #147031 (mbe: Simplify check_redundant_vis_repetition)
 - #147058 (Ignore more failing ui tests for GCC backend)

Failed merges:

 - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 27, 2025
@bors
Auto merge of #147074 - matthiaskrgr:rollup-sm3owsd, r=matthiaskrgr
e131842 
Rollup of 10 pull requests

Successful merges:

 - #145113 (resolve: Do not finalize shadowed bindings)
 - #146523 (Demote both armebv7r-none-* targets.)
 - #146704 (port `#[debugger_visualizer]` to the new attribute system)
 - #146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu)
 - #146778 (Use standard attribute logic for allocator shim)
 - #146849 (Reduce some uses of `LegacyBang`)
 - #147016 (fix doc comments to be more standard)
 - #147027 (Add new `tyalias` intra-doc link disambiguator)
 - #147031 (mbe: Simplify check_redundant_vis_repetition)
 - #147058 (Ignore more failing ui tests for GCC backend)

Failed merges:

 - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a91918f into rust-lang:master Sep 27, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 27, 2025
@rust-timer
Unrolled build for #147058
39d875a 
Rollup merge of #147058 - GuillaumeGomez:ignore-more-ui-tests, r=Kobzol

Ignore more failing ui tests for GCC backend

Needed for #146414.

r? ``@Kobzol``
@rustbot rustbot added this to the 1.92.0 milestone Sep 27, 2025
@GuillaumeGomez GuillaumeGomez deleted the ignore-more-ui-tests branch September 27, 2025 09:28
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Sep 29, 2025
@bors
Auto merge of #147074 - matthiaskrgr:rollup-sm3owsd, r=matthiaskrgr
0d1311a 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145113 (resolve: Do not finalize shadowed bindings)
 - rust-lang/rust#146523 (Demote both armebv7r-none-* targets.)
 - rust-lang/rust#146704 (port `#[debugger_visualizer]` to the new attribute system)
 - rust-lang/rust#146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu)
 - rust-lang/rust#146778 (Use standard attribute logic for allocator shim)
 - rust-lang/rust#146849 (Reduce some uses of `LegacyBang`)
 - rust-lang/rust#147016 (fix doc comments to be more standard)
 - rust-lang/rust#147027 (Add new `tyalias` intra-doc link disambiguator)
 - rust-lang/rust#147031 (mbe: Simplify check_redundant_vis_repetition)
 - rust-lang/rust#147058 (Ignore more failing ui tests for GCC backend)

Failed merges:

 - rust-lang/rust#147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
F-explicit_tail_calls `#![feature(explicit_tail_calls)]` PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rustbot @rust-log-analyzer @Kobzol @nikic @bors