Skip to content

std_detect: Support run-time detection on OpenBSD using elf_aux_info #147024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2025
Merged

std_detect: Support run-time detection on OpenBSD using elf_aux_info #147024

merged 1 commit into from
Nov 9, 2025
+107 −5

Conversation

@brad0
Copy link
Contributor

@brad0 brad0 commented Sep 25, 2025

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 429f929 to 943b406 Compare September 25, 2025 12:45
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 28, 2025

@semarie, could you help review that this is the right way to detect platform features as the relevant target maintainer?

(per https://doc.rust-lang.org/nightly/rustc/platform-support/openbsd.html)

@semarie
Copy link
Contributor

semarie commented Sep 29, 2025

The logic seems good (but not deeply checked for now), but it shouldn't be merged at this stage.

@brad0 could you first look to make elf_aux_info function available for OpenBSD in rust libc ? else, the build will just break due to undefined function.

the steps are:

  • add elf_aux_info(3) in Rust libc
  • hvae it backported to 0.2 branch (should be automatic for such change)
  • have a new release of libc crate with it
  • update rust compiler to use this version of the crate

Once all is done, the PR could be considered.
Thanks.

@semarie semarie mentioned this pull request Sep 29, 2025
Merged
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025
@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 943b406 to 5231fbc Compare October 8, 2025 23:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 5231fbc to 1f6d6fb Compare October 9, 2025 00:06
@brad0
Copy link
Contributor Author

brad0 commented Oct 10, 2025

@semarie So the libc part has been completed.

@semarie
Copy link
Contributor

semarie commented Oct 15, 2025

sorry to reply a bit late. does the rust libc version has been updated in rustc to be able to use elf_aux_info() ?

@brad0
Copy link
Contributor Author

brad0 commented Oct 15, 2025

sorry to reply a bit late. does the rust libc version has been updated in rustc to be able to use elf_aux_info() ?

Until libc is updated no rush.

There is an issue open requesting an unpin of libc to bump it up. Waiting on that for now.

#147501

@brad0 brad0 force-pushed the std_detect_openbsd_elf_aux_info branch from 1f6d6fb to cb0a705 Compare November 2, 2025 20:11
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@brad0
Copy link
Contributor Author

brad0 commented Nov 2, 2025

sorry to reply a bit late. does the rust libc version has been updated in rustc to be able to use elf_aux_info() ?

It looks as if this has been completed.

semarie
semarie approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@semarie semarie left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it built fine on OpenBSD, and changes look good.
so LGTM, thanks.

View changes since this review

@semarie
Copy link
Contributor

semarie commented Nov 5, 2025

@Mark-Simulacrum could you r+ it, please ?

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Nov 8, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 8, 2025

📌 Commit cb0a705 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2025
Merged
bors added a commit that referenced this pull request Nov 8, 2025
@bors
Auto merge of #148692 - matthiaskrgr:rollup-hryk71f, r=matthiaskrgr
e3cb0e3 
Rollup of 10 pull requests

Successful merges:

 - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro)
 - #147024 (std_detect: Support run-time detection on OpenBSD using elf_aux_info)
 - #147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - #147540 (Stabilise `as_array` in `[_]` and `*const [_]`; stabilise `as_mut_array` in `[_]` and `*mut [_]`.)
 - #147686 (update isolate_highest_one for NonZero<T>)
 - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - #148555 (Fix rust-by-example spanish translation)
 - #148556 (Fix suggestion for returning async closures)
 - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 8, 2025
@bors
Auto merge of #148692 - matthiaskrgr:rollup-hryk71f, r=matthiaskrgr
328779c 
Rollup of 10 pull requests

Successful merges:

 - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro)
 - #147024 (std_detect: Support run-time detection on OpenBSD using elf_aux_info)
 - #147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - #147540 (Stabilise `as_array` in `[_]` and `*const [_]`; stabilise `as_mut_array` in `[_]` and `*mut [_]`.)
 - #147686 (update isolate_highest_one for NonZero<T>)
 - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - #148555 (Fix rust-by-example spanish translation)
 - #148556 (Fix suggestion for returning async closures)
 - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 9, 2025
@bors
Auto merge of #148692 - matthiaskrgr:rollup-hryk71f, r=matthiaskrgr
acda5e9 
Rollup of 10 pull requests

Successful merges:

 - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro)
 - #147024 (std_detect: Support run-time detection on OpenBSD using elf_aux_info)
 - #147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - #147540 (Stabilise `as_array` in `[_]` and `*const [_]`; stabilise `as_mut_array` in `[_]` and `*mut [_]`.)
 - #147686 (update isolate_highest_one for NonZero<T>)
 - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - #148555 (Fix rust-by-example spanish translation)
 - #148556 (Fix suggestion for returning async closures)
 - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da171df into rust-lang:master Nov 9, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 9, 2025
rust-timer added a commit that referenced this pull request Nov 9, 2025
@rust-timer
Unrolled build for #147024
85332f2 
Rollup merge of #147024 - brad0:std_detect_openbsd_elf_aux_info, r=Mark-Simulacrum

std_detect: Support run-time detection on OpenBSD using elf_aux_info
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Nov 10, 2025
@bors
Auto merge of #148692 - matthiaskrgr:rollup-hryk71f, r=matthiaskrgr
925a587 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro)
 - rust-lang/rust#147024 (std_detect: Support run-time detection on OpenBSD using elf_aux_info)
 - rust-lang/rust#147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - rust-lang/rust#147540 (Stabilise `as_array` in `[_]` and `*const [_]`; stabilise `as_mut_array` in `[_]` and `*mut [_]`.)
 - rust-lang/rust#147686 (update isolate_highest_one for NonZero<T>)
 - rust-lang/rust#148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - rust-lang/rust#148555 (Fix rust-by-example spanish translation)
 - rust-lang/rust#148556 (Fix suggestion for returning async closures)
 - rust-lang/rust#148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - rust-lang/rust#148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 10, 2025
@bors
Auto merge of #148692 - matthiaskrgr:rollup-hryk71f, r=matthiaskrgr
b3e6804 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro)
 - rust-lang/rust#147024 (std_detect: Support run-time detection on OpenBSD using elf_aux_info)
 - rust-lang/rust#147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - rust-lang/rust#147540 (Stabilise `as_array` in `[_]` and `*const [_]`; stabilise `as_mut_array` in `[_]` and `*mut [_]`.)
 - rust-lang/rust#147686 (update isolate_highest_one for NonZero<T>)
 - rust-lang/rust#148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - rust-lang/rust#148555 (Fix rust-by-example spanish translation)
 - rust-lang/rust#148556 (Fix suggestion for returning async closures)
 - rust-lang/rust#148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - rust-lang/rust#148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 10, 2025
@bors
Auto merge of #148692 - matthiaskrgr:rollup-hryk71f, r=matthiaskrgr
d8a1511 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro)
 - rust-lang/rust#147024 (std_detect: Support run-time detection on OpenBSD using elf_aux_info)
 - rust-lang/rust#147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - rust-lang/rust#147540 (Stabilise `as_array` in `[_]` and `*const [_]`; stabilise `as_mut_array` in `[_]` and `*mut [_]`.)
 - rust-lang/rust#147686 (update isolate_highest_one for NonZero<T>)
 - rust-lang/rust#148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - rust-lang/rust#148555 (Fix rust-by-example spanish translation)
 - rust-lang/rust#148556 (Fix suggestion for returning async closures)
 - rust-lang/rust#148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - rust-lang/rust#148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@semarie semarie semarie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@brad0 @rustbot @rust-log-analyzer @Mark-Simulacrum @semarie @bors