Rollup of 7 pull requests #146685

jdonszelmann · 2025-09-17T18:29:39Z

Successful merges:

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
Remove unsized arg handling in ArgAbiBuilderMethods::store_fn_arg implementations #146485 (Remove unsized arg handling in ArgAbiBuilderMethods::store_fn_arg implementations)
clean up several trait related UI tests #146536 (clean up several trait related UI tests)
Make llvm_enzyme a regular cargo feature #146598 (Make llvm_enzyme a regular cargo feature)
Move #[rustc_coherence_is_core] to the crate_level file #146647 (Move #[rustc_coherence_is_core] to the crate_level file)
Do not use git -C dir #146654 (Do not use git -C dir)
Add space after brace in Box<[T]>::new_uninit_slice example #146681 (Add space after brace in Box<[T]>::new_uninit_slice example)

r? @ghost
@rustbot modify labels: rollup

…n codegen

This makes it clearer that it is set by the build system rather than by the rustc that compiles the current rustc. It also avoids bootstrap needing to pass --check-cfg llvm_enzyme to rustc.

…aded parallel compilation

Older versions of git (≤ 1.8.5) do not support the `-C dir` global option. Use the `cwd` optional argument when using Python's `subprocess` functionality instead.

…tructure

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation Add the option to use the parallel compiler when building Rust code in bootstrap.

…=davidtwco Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations ... since it is unreachable and would ICE anyway. These branches are unreachable with how `store_fn_arg` is currently used (where it is called, unsized arguments are either: 1. not (yet) supported, or 2. handled differently)[^1], and even if they were reachable, they would ICE anyway, since they call [`OperandValue::store`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_codegen_ssa/mir/operand.rs.html#855-861), which calls [`OperandValue::store_with_flags`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_codegen_ssa/mir/operand.rs.html#887-926) which [panics on any unsized layout](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_codegen_ssa/mir/operand.rs.html#900-903). Also updates the `bug!` message in `store_arg` to not suggest `store_fn_arg` for unsized args. [^1]: `store_fn_arg` is only nontrivially[^2] called in `compiler/rustc_codegen_ssa/src/mir/mod.rs` for: Line 428 `extern "rust-call"` tuple (un)splitting, which does not support unsized arguments, Line 496 which is only for sized `PassMode::Indirect` (`meta_attrs: None`) arguments, and Line 521 which is only for non-`PassMode::Indirect` arguments which can never be unsized. [^2]: `<Bx as ArgAbiBuilderMethods>::store_fn_arg` is what is actually called, but codegen_llvm and codegen_gcc's builders both delegate to their own `codegen_crate::ArgAbiExt::store_fn_arg`, which contain the actual implementations that are changed in this PR.

…ui-tests, r=davidtwco clean up several trait related UI tests Part of rust-lang#133895 Cleaned up several `issue-xxxx` trait related tests from `/tests/ui/issues`, one commit per issue for review. Will squash them once approved. Related issues: rust-lang#19479 rust-lang#2284 rust-lang#18088 rust-lang#21950

…dtwco Make llvm_enzyme a regular cargo feature This makes it clearer that it is set by the build system rather than by the rustc that compiles the current rustc. It also avoids bootstrap needing to pass `--check-cfg llvm_enzyme` to rustc.

…e, r=urgau Move `#[rustc_coherence_is_core]` to the `crate_level` file I implemented this one without realizing it already was since it was (in my opinion) in the wrong file and implemented in a batch of all non-crate-level attributes. This commit just cleans it up slightly and moves it. Should be trivial r? `@oli-obk`

Do not use `git -C dir` Older versions of git (≤ 1.8.5) do not support the `-C dir` global option. Use the `cwd` optional argument when using Python's `subprocess` functionality instead. Fix rust-lang#142534

Add space after brace in `Box<[T]>::new_uninit_slice` example Trivial cosmetic change.

jdonszelmann · 2025-09-17T18:31:07Z

@bors r+ p=5 rollup=never

bors · 2025-09-17T18:31:10Z

📌 Commit c6ed4c0 has been approved by jdonszelmann

It is now in the queue for this repository.

bors · 2025-09-17T21:26:54Z

⌛ Testing commit c6ed4c0 with merge 9311767...

bors · 2025-09-18T00:34:52Z

☀️ Test successful - checks-actions
Approved by: jdonszelmann
Pushing 9311767 to master...

rust-timer · 2025-09-18T00:36:54Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146458	Add parallel-frontend-threads to bootstrap.toml and enable …	`406d131c73218e1f86394d8427c4597873f11d6a` (link)
#146485	Remove unsized arg handling in `ArgAbiBuilderMethods::store…	`e1bf8772a74e3491d581abd8ec304e9d9d01201e` (link)
#146536	clean up several trait related UI tests	`a5d56cac3cf4fc606501d24e680f4632516d68dc` (link)
#146598	Make llvm_enzyme a regular cargo feature	`03888718e900edf2586ee45b5ec98f2e86eb7fd9` (link)
#146647	Move `#[rustc_coherence_is_core]` to the `crate_level` file	`04993dbbbe432bf8ce47897017d21bc553ebf5e4` (link)
#146654	Do not use `git -C dir`	`5beda5df1a93c3ae23c2381a05a5501efed88ae4` (link)
#146681	Add space after brace in `Box<[T]>::new_uninit_slice` examp…	`5a79bf168ea5778de7428f05dffcb3d4f80d171c` (link)

previous master: 4645a79881

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-18T00:38:12Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4645a79 (parent) -> 9311767 (this PR)

Test differences

Show 18 test diffs

Stage 1

[ui] tests/ui/issues/issue-18088.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-19479.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-21950.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-2284.rs: pass -> [missing] (J0)
[ui] tests/ui/traits/associated_type_bound/assoc-type-via-another-trait-issue-19479.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/cast-as-dyn-trait-wo-assoc-type-issue-21950.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/core-marker-name-shadowing-issue-2284.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/inheritance/supertrait-operator-issue-18088.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/issues/issue-18088.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-19479.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-21950.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-2284.rs: pass -> [missing] (J1)
[ui] tests/ui/traits/associated_type_bound/assoc-type-via-another-trait-issue-19479.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/cast-as-dyn-trait-wo-assoc-type-issue-21950.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/core-marker-name-shadowing-issue-2284.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/inheritance/supertrait-operator-issue-18088.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 93117677d857bb7c3f12c9dc500d77839f8fb13d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4394.9s -> 3512.2s (-20.1%)
x86_64-rust-for-linux: 2596.0s -> 3087.0s (18.9%)
x86_64-gnu-llvm-20: 2407.5s -> 2844.8s (18.2%)
dist-aarch64-apple: 8500.3s -> 7233.2s (-14.9%)
i686-gnu-2: 5528.6s -> 6330.2s (14.5%)
i686-gnu-nopt-1: 7063.2s -> 8075.5s (14.3%)
aarch64-gnu-debug: 3730.5s -> 4237.4s (13.6%)
pr-check-2: 2142.7s -> 2403.3s (12.2%)
x86_64-gnu-llvm-20-2: 5425.8s -> 6059.4s (11.7%)
x86_64-gnu-miri: 4435.5s -> 4941.6s (11.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-18T01:46:16Z

Finished benchmarking commit (9311767): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.1%, -2.2%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.629s -> 471.663s (0.01%)
Artifact size: 387.93 MiB -> 387.94 MiB (0.00%)

zachs18 and others added 17 commits September 12, 2025 09:49

Remove unreachable unsized arg handling in store_fn_arg/store_arg i…

baed55c

…n codegen

clean up issue-2284 (core marker trait name shadowing)

619a696

clean up issue-19479 (assoc type from another trait)

05a5c7d

clean up issue-18088 (operator from supertrait)

8ee3a08

clean up issue-21950 (dyn trait cast without assoc type at the cast)

22aecd3

Make llvm_enzyme a regular cargo feature

1991779

This makes it clearer that it is set by the build system rather than by the rustc that compiles the current rustc. It also avoids bootstrap needing to pass --check-cfg llvm_enzyme to rustc.

Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…

929c933

…aded parallel compilation

Do not use git -C dir

b79a4bf

Older versions of git (≤ 1.8.5) do not support the `-C dir` global option. Use the `cwd` optional argument when using Python's `subprocess` functionality instead.

Add space after brace in Box<[T]>::new_uninit_slice example

b2b43b2

port #[rustc_coherence_is_core] to the new attribute parsing infras…

205189c

…tructure

Rollup merge of rust-lang#146458 - Hayden602:bootstrap, r=Kobzol

0a2be63

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation Add the option to use the parallel compiler when building Rust code in bootstrap.

Rollup merge of rust-lang#146654 - samueltardieu:issue142534, r=Kobzol

b8a80e4

Do not use `git -C dir` Older versions of git (≤ 1.8.5) do not support the `-C dir` global option. Use the `cwd` optional argument when using Python's `subprocess` functionality instead. Fix rust-lang#142534

Rollup merge of rust-lang#146681 - XrXr:patch-1, r=joboet

c6ed4c0

Add space after brace in `Box<[T]>::new_uninit_slice` example Trivial cosmetic change.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2025

bors merged commit 9311767 into rust-lang:master Sep 18, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 18, 2025

This was referenced Sep 18, 2025

Allow lld to be enabled on aarch64-unknown-linux-gnu #146604

Open

libload / dlopen Enzyme/autodiff #146623

Draft

Allow windows resource compiler to be overridden #146663

Merged

Rollup of 4 pull requests #146695

Closed

github-actions bot mentioned this pull request Sep 22, 2025

Toolchain upgrade to nightly-2025-09-23 flux-rs/flux#1271

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #146685

Rollup of 7 pull requests #146685

Uh oh!

jdonszelmann commented Sep 17, 2025 •

edited by rustbot

Loading

Uh oh!

jdonszelmann commented Sep 17, 2025

Uh oh!

bors commented Sep 17, 2025

Uh oh!

bors commented Sep 17, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 18, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #146685

Rollup of 7 pull requests #146685

Uh oh!

Conversation

jdonszelmann commented Sep 17, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Sep 17, 2025

Uh oh!

bors commented Sep 17, 2025

Uh oh!

bors commented Sep 17, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 18, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

jdonszelmann commented Sep 17, 2025 •

edited by rustbot

Loading