std: reorganize the UNIX-internal weak module
#146629
Merged
+232
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
rustbot
added
the
T-libs
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
reorganize-weak
branch
from
de0f81e to
e806929
Compare
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
reorganize-weak
branch
from
e806929 to
0af3db5
Compare
ibraheemdev
reviewed
Oct 14, 2025
|
Looks good. r=me after the nit. |
ibraheemdev
added
S-waiting-on-author
joboet
force-pushed
the
reorganize-weak
branch
from
0af3db5 to
e043a0b
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
std: reorganize the UNIX-internal `weak` module This moves the `dlsym`-based and weak-linkage versions of the `weak!` macro into separate files, both of which include a common test file. As a result, both versions will be tested on all the platforms where they are used. Since the `#[link_name]` arm of the `dlsym` version was unused, I've removed it. I've also removed the unused `raw_syscall!` and non-Linux `syscall!` macros and gated the `#[allow(dead_code, unused_macros)]` to only apply on non-Linux platforms, so compilation will fail if `weak` turns out to be unused on all platforms. The last change concerns the use of `dlsym!` on FreeBSD: it is only used once, to link against `sysctlbyname`. But that symbol is always available, so there is no need for weak linkage.
This was referenced Oct 22, 2025
bors
added a commit
that referenced
this pull request
Oct 23, 2025
Rollup of 4 pull requests Successful merges: - #115501 (Add new inherit_handles flag to CommandExt trait) - #146629 (std: reorganize the UNIX-internal `weak` module) - #147762 (feat(rustdoc): `--emit=depinfo` output to stdout via `-`) - #148001 (fix: Don't add diff symbol to unchanged lines) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 23, 2025
Rollup merge of #146629 - joboet:reorganize-weak, r=ibraheemdev std: reorganize the UNIX-internal `weak` module This moves the `dlsym`-based and weak-linkage versions of the `weak!` macro into separate files, both of which include a common test file. As a result, both versions will be tested on all the platforms where they are used. Since the `#[link_name]` arm of the `dlsym` version was unused, I've removed it. I've also removed the unused `raw_syscall!` and non-Linux `syscall!` macros and gated the `#[allow(dead_code, unused_macros)]` to only apply on non-Linux platforms, so compilation will fail if `weak` turns out to be unused on all platforms. The last change concerns the use of `dlsym!` on FreeBSD: it is only used once, to link against `sysctlbyname`. But that symbol is always available, so there is no need for weak linkage.
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Oct 27, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#115501 (Add new inherit_handles flag to CommandExt trait) - rust-lang/rust#146629 (std: reorganize the UNIX-internal `weak` module) - rust-lang/rust#147762 (feat(rustdoc): `--emit=depinfo` output to stdout via `-`) - rust-lang/rust#148001 (fix: Don't add diff symbol to unchanged lines) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
dlsym-based and weak-linkage versions of theweak!macro into separate files, both of which include a common test file. As a result, both versions will be tested on all the platforms where they are used.Since the
#[link_name]arm of thedlsymversion was unused, I've removed it. I've also removed the unusedraw_syscall!and non-Linuxsyscall!macros and gated the#[allow(dead_code, unused_macros)]to only apply on non-Linux platforms, so compilation will fail ifweakturns out to be unused on all platforms.The last change concerns the use of
dlsym!on FreeBSD: it is only used once, to link againstsysctlbyname. But that symbol is always available, so there is no need for weak linkage.