bootstrap: rustdoc-js tests can now be filtered by js files #146450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
I wouldn't worry about the clone, and just always convert to |
jieyouxu
approved these changes
Sep 13, 2025
jieyouxu
reviewed
Sep 13, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 13, 2025
Rollup of 5 pull requests Successful merges: - #144498 (Add --print target-spec-json-schema) - #145471 (Stabilize BTree{Map,Set}::extract_if) - #145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#3 of Batch #2]) - #146450 (bootstrap: rustdoc-js tests can now be filtered by js files) - #146456 (Fix panic and incorrectly suggested examples in `format_args` macro.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 13, 2025
Rollup merge of #146450 - lolbinarycat:bootstrap-test-js, r=jieyouxu bootstrap: rustdoc-js tests can now be filtered by js files Before, a command like `./x test tests/rustdoc-js/path-ordering.js` would succeed, but run no tests, since the names of the tests are based on the `.rs` file. This is a bit confusing, as the `rustdoc-js-std` test suite only has `.js` files, and thus those are the files you filter on. Now, `./x test tests/rustdoc-js/path-ordering.js` will be treated as an alias for `./x test tests/rustdoc-js/path-ordering.rs`. This is fairly simple as each `rustdoc-js` test has 2 files, 1 js file and one rust file, each with an identical base filename, so all we need to do is swap the extension. r? `@Kobzol`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 14, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#144498 (Add --print target-spec-json-schema) - rust-lang/rust#145471 (Stabilize BTree{Map,Set}::extract_if) - rust-lang/rust#145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang/rust#3 of Batch rust-lang/rust#2]) - rust-lang/rust#146450 (bootstrap: rustdoc-js tests can now be filtered by js files) - rust-lang/rust#146456 (Fix panic and incorrectly suggested examples in `format_args` macro.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, a command like
./x test tests/rustdoc-js/path-ordering.jswould succeed, but run no tests, since the names of the tests are based on the.rsfile. This is a bit confusing, as therustdoc-js-stdtest suite only has.jsfiles, and thus those are the files you filter on. Now,./x test tests/rustdoc-js/path-ordering.jswill be treated as an alias for./x test tests/rustdoc-js/path-ordering.rs. This is fairly simple as eachrustdoc-jstest has 2 files, 1 js file and one rust file, each with an identical base filename, so all we need to do is swap the extension.r? @Kobzol