Skip to content

Misc LTO cleanups #146209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2025
Merged

Misc LTO cleanups #146209

merged 3 commits into from
Sep 7, 2025

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 4, 2025 •
edited
Loading

Follow up to #145955.

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This was referenced Sep 4, 2025
Merged
Closed
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 5, 2025

Blocked on #146232.

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025
@rustbot

This comment has been minimized.

Sign in to view
@bjorn3
Remove thin_link_data method from ThinBufferMethods
e3d0b7d 
It is only used within cg_llvm.
@bjorn3
Remove want_summary argument from prepare_thin
f2933b3 
It is always false nowadays. ThinLTO summary writing is instead done by
llvm_optimize.
@bjorn3
Move timers into execute_*_work_item
3a1ae06
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3
Copy link
Member Author

bjorn3 commented Sep 6, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 6, 2025
dianqk
dianqk approved these changes Sep 7, 2025
View reviewed changes
Copy link
Member

@dianqk dianqk left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! r=me
r? dianqk

View changes since this review

@rustbot rustbot assigned dianqk and unassigned workingjubilee Sep 7, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 7, 2025

@bors r=dianqk

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit 3a1ae06 has been approved by dianqk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2025
Merged
bors added a commit that referenced this pull request Sep 7, 2025
@bors
Auto merge of #146304 - matthiaskrgr:rollup-69hs07h, r=matthiaskrgr
12eb345 
Rollup of 4 pull requests

Successful merges:

 - #146170 (fix: offline rustdoc html missing favicon)
 - #146209 (Misc LTO cleanups)
 - #146269 (feat(std): emulate flock for solaris via fcntl)
 - #146297 (Introduce PlaceContext::may_observe_address.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 92bad93 into rust-lang:master Sep 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
rust-timer added a commit that referenced this pull request Sep 7, 2025
@rust-timer
Unrolled build for #146209
d2c3e34 
Rollup merge of #146209 - bjorn3:lto_refactors5, r=dianqk

Misc LTO cleanups

Follow up to #145955.

* Remove want_summary argument from `prepare_thin`.
   Since #133250 ThinLTO summary writing is instead done by `llvm_optimize`.
* Two minor cleanups
@matthiaskrgr
Copy link
Member

@rust-timer build d2c3e34

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d2c3e34): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.642s -> 468.134s (0.11%)
Artifact size: 387.46 MiB -> 387.46 MiB (0.00%)

@bjorn3 bjorn3 deleted the lto_refactors5 branch September 8, 2025 09:25
@bjorn3 bjorn3 mentioned this pull request Oct 17, 2025
Merged
bors added a commit that referenced this pull request Oct 22, 2025
@bors
Auto merge of #147810 - bjorn3:lto_refactors6, r=wesleywiser
6244eff 
Split LTO out of the main codegen coordinator event loop into a separate event loop on the same thread

This will make it easier to in the future move all this code to link_binary.

Follow up to #146209
Part of rust-lang/compiler-team#908
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 23, 2025
@bors
Auto merge of #147810 - bjorn3:lto_refactors6, r=wesleywiser
2b788f9 
Split LTO out of the main codegen coordinator event loop into a separate event loop on the same thread

This will make it easier to in the future move all this code to link_binary.

Follow up to rust-lang/rust#146209
Part of rust-lang/compiler-team#908
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Oct 27, 2025
@bors
Auto merge of #147810 - bjorn3:lto_refactors6, r=wesleywiser
3c5e16e 
Split LTO out of the main codegen coordinator event loop into a separate event loop on the same thread

This will make it easier to in the future move all this code to link_binary.

Follow up to rust-lang/rust#146209
Part of rust-lang/compiler-team#908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dianqk dianqk dianqk approved these changes

Assignees

@dianqk dianqk

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

7 participants

@bjorn3 @rustbot @bors @matthiaskrgr @rust-timer @dianqk @workingjubilee