-
Couldn't load subscription status.
- Fork 13.9k
Update cc-rs to 1.2.39 #146186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cc-rs to 1.2.39 #146186
Conversation
|
Failed to set assignee to
|
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in compiler/rustc_codegen_ssa |
|
@bors try jobs=aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various |
This comment has been minimized.
This comment has been minimized.
Update cc-rs to 1.2.33 try-job: aarch64-msvc-1 try-job: aarch64-apple try-job: test-various try-job: dist-apple-various
|
Let me know @dpaoliello if you want to try with |
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
|
I switched to @rustbot ready |
This comment has been minimized.
This comment has been minimized.
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
|
@bors r=davidtwco,jieyouxu |
|
💔 Test for 9cd2e4c failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
|
Retrying... |
Update cc-rs to 1.2.39 try-job: dist-aarch64-linux try-job: aarch64-msvc-1 try-job: aarch64-apple try-job: test-various try-job: dist-apple-various
This comment has been minimized.
This comment has been minimized.
|
@rustbot ready |
|
@dpaoliello could you squash the commits and fixup the commit message to say 1.2.39 instead of 1.2.33 (from the previous attempts)? Otherwise, this looks good to me. |
|
@rustbot author |
|
Done @rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bors r+ rollup=never |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c9537a9 (parent) -> bc1d727 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard bc1d7273dfbc6f8a11c0086fa35f6748a13e8d3c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
For my purposes, contains fixes when compiling the Rust compiler for Arm64EC.
Checked the commits since 1.2.16, and I don't see anything else that may affect Rust?
find-msvc-toolswas also factored out fromccto allow updating the use inrustc_codegen_ssa(finding the linker when running the Rust compiler) to be separate from the use inrustc_llvm(building LLVM as part of the Rust compiler).