Skip to content

Conversation

@dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Sep 4, 2025

For my purposes, contains fixes when compiling the Rust compiler for Arm64EC.

Checked the commits since 1.2.16, and I don't see anything else that may affect Rust?

find-msvc-tools was also factored out from cc to allow updating the use in rustc_codegen_ssa (finding the linker when running the Rust compiler) to be separate from the use in rustc_llvm (building LLVM as part of the Rust compiler).

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Failed to set assignee to NobodyXu: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@jieyouxu jieyouxu self-assigned this Sep 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

@bors try jobs=aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 4, 2025
Update cc-rs to 1.2.33

try-job: aarch64-msvc-1
try-job: aarch64-apple
try-job: test-various
try-job: dist-apple-various
@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

☀️ Try build successful (CI)
Build commit: d8ac12e (d8ac12e3b0cef5271092800d62ab852417973355, parent: a1208bf765ba783ee4ebdc4c29ab0a0c215806ef)

@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

Let me know @dpaoliello if you want to try with find-msvc-tools, otherwise I'm fine with the current change as well.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot

This comment has been minimized.

@dpaoliello dpaoliello changed the title Update cc-rs to 1.2.33 Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools Sep 4, 2025
@dpaoliello
Copy link
Contributor Author

I switched to find-msvc-tools, since I was here changing things.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@davidtwco
Copy link
Member

@bors r=davidtwco,jieyouxu

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 45a0e10 has been approved by davidtwco,jieyouxu

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 24, 2025

💔 Test for 9cd2e4c failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

@dpaoliello
Copy link
Contributor Author

try failure looks like a docker timeout.

Retrying...
@bors2 try jobs=dist-aarch64-linux,aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various

rust-bors bot added a commit that referenced this pull request Oct 24, 2025
Update cc-rs to 1.2.39

try-job: dist-aarch64-linux
try-job: aarch64-msvc-1
try-job: aarch64-apple
try-job: test-various
try-job: dist-apple-various
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Oct 24, 2025

☀️ Try build successful (CI)
Build commit: c2755aa (c2755aadb42e9221ae8576d267a57d65307ee733, parent: ab925646fae038b02bd462cd328ae9eef1639236)

@dpaoliello dpaoliello marked this pull request as ready for review October 24, 2025 20:35
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2025
@dpaoliello
Copy link
Contributor Author

@rustbot ready

@jieyouxu
Copy link
Member

@dpaoliello could you squash the commits and fixup the commit message to say 1.2.39 instead of 1.2.33 (from the previous attempts)? Otherwise, this looks good to me.

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2025
@dpaoliello
Copy link
Contributor Author

Done

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Oct 28, 2025

📌 Commit 826c925 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2025
@bors
Copy link
Collaborator

bors commented Oct 28, 2025

⌛ Testing commit 826c925 with merge bc1d727...

@bors
Copy link
Collaborator

bors commented Oct 28, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing bc1d727 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2025
@bors bors merged commit bc1d727 into rust-lang:master Oct 28, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 28, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c9537a9 (parent) -> bc1d727 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bc1d7273dfbc6f8a11c0086fa35f6748a13e8d3c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-loongarch64-musl: 10893.4s -> 5156.0s (-52.7%)
  2. dist-loongarch64-linux: 11354.2s -> 5538.0s (-51.2%)
  3. pr-check-1: 1890.9s -> 1300.6s (-31.2%)
  4. aarch64-apple: 8224.5s -> 6892.9s (-16.2%)
  5. armhf-gnu: 4783.2s -> 5547.6s (16.0%)
  6. dist-apple-various: 3959.6s -> 4533.5s (14.5%)
  7. x86_64-gnu-llvm-20-1: 3700.0s -> 3255.6s (-12.0%)
  8. dist-i586-gnu-i586-i686-musl: 5332.8s -> 4750.4s (-10.9%)
  9. dist-x86_64-apple: 6383.1s -> 7051.9s (10.5%)
  10. x86_64-gnu-llvm-20-2: 5415.8s -> 5973.3s (10.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants