Skip to content

remove some unused private trait impls #145111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

remove some unused private trait impls #145111

merged 1 commit into from
Aug 11, 2025

Conversation

@fee1-dead
Copy link
Member

they're neither required for completeness nor used

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025
jieyouxu
jieyouxu approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meow

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 11, 2025

📌 Commit 57dc64e has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned davidtwco Aug 11, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 11, 2025
Merged
bors added a commit that referenced this pull request Aug 11, 2025
@bors
Auto merge of #145254 - GuillaumeGomez:rollup-7bp43pv, r=GuillaumeGomez
1ebbd87 
Rollup of 4 pull requests

Successful merges:

 - #144966 ( Improve suggestion for "missing function argument" on multiline call)
 - #145111 (remove some unused private trait impls)
 - #145221 (Fix Cargo cross-compilation (take two))
 - #145247 (Update `sysinfo` version to `0.37.0`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 77d7a2c into rust-lang:master Aug 11, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 11, 2025
rust-timer added a commit that referenced this pull request Aug 11, 2025
@rust-timer
Unrolled build for #145111
1537297 
Rollup merge of #145111 - fee1-dead-contrib:push-rlvnyrztlkpq, r=jieyouxu

remove some unused private trait impls

they're neither required for completeness nor used
@fee1-dead fee1-dead deleted the push-rlvnyrztlkpq branch October 22, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@fee1-dead @rustbot @jieyouxu @bors @davidtwco