Improve error output when a command fails in bootstrap #145089

Kobzol · 2025-08-08T11:17:25Z

I fixed this because it was being an issue for debugging CI failures.

We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand.

I also fixed the format_short_cmd logic, it was a bit weird after some recent refactors.

Fixes: #145002

r? @jieyouxu

CC @Shourya742

jieyouxu · 2025-08-08T11:55:15Z

you got clippy'd 😁

Kobzol · 2025-08-08T15:26:58Z

Ok, should be good now.

Shourya742

ACK. Some minor non-blocking questions..

src/bootstrap/src/utils/exec.rs

jieyouxu

Thanks

src/bootstrap/src/utils/exec.rs

jieyouxu · 2025-08-09T08:53:37Z

@bors r+ rollup

bors · 2025-08-09T08:53:40Z

📌 Commit d9b725a has been approved by jieyouxu

It is now in the queue for this repository.

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? `@jieyouxu` CC `@Shourya742`

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? ``@jieyouxu`` CC ``@Shourya742``

Rollup of 8 pull requests Successful merges: - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145135 (Stabilize `duration_constructors_lite` feature) - #145146 (remove `P`) - #145152 (Use `to_ascii_lowercase` to avoid heap alloc in `detect_confuse_type`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) Failed merges: - #145145 (some `derive_more` refactors) r? `@ghost` `@rustbot` modify labels: rollup

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? ```@jieyouxu``` CC ```@Shourya742```

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? ````@jieyouxu```` CC ````@Shourya742````

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? `````@jieyouxu````` CC `````@Shourya742`````

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? ``````@jieyouxu`````` CC ``````@Shourya742``````

Rollup of 19 pull requests Successful merges: - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones) - #143093 (Simplify polonius location-sensitive analysis) - #144402 (Stabilize loongarch32 inline asm) - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N]) - #144544 (Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies) - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC) - #145130 (improve "Documentation problem" issue template.) - #145135 (Stabilize `duration_constructors_lite` feature) - #145145 (some `derive_more` refactors) - #145147 (rename `TraitRef::from_method` to `from_assoc`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading) - #145175 (Enable limit_rdylib_exports on Solaris) - #145187 (Fix an unstable feature comment that wasn't a doc comment) - #145191 (`suggest_borrow_generic_arg`: use the correct generic args) r? `@ghost` `@rustbot` modify labels: rollup

…ouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: rust-lang#145002 r? ```````@jieyouxu``````` CC ```````@Shourya742```````

Rollup of 18 pull requests Successful merges: - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones) - #143093 (Simplify polonius location-sensitive analysis) - #144402 (Stabilize loongarch32 inline asm) - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N]) - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC) - #145130 (improve "Documentation problem" issue template.) - #145135 (Stabilize `duration_constructors_lite` feature) - #145145 (some `derive_more` refactors) - #145147 (rename `TraitRef::from_method` to `from_assoc`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading) - #145175 (Enable limit_rdylib_exports on Solaris) - #145187 (Fix an unstable feature comment that wasn't a doc comment) - #145191 (`suggest_borrow_generic_arg`: use the correct generic args) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones) - #143093 (Simplify polonius location-sensitive analysis) - #144402 (Stabilize loongarch32 inline asm) - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N]) - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC) - #145130 (improve "Documentation problem" issue template.) - #145135 (Stabilize `duration_constructors_lite` feature) - #145145 (some `derive_more` refactors) - #145147 (rename `TraitRef::from_method` to `from_assoc`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading) - #145187 (Fix an unstable feature comment that wasn't a doc comment) - #145191 (`suggest_borrow_generic_arg`: use the correct generic args) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145089 - Kobzol:bootstrap-cmd-error, r=jieyouxu Improve error output when a command fails in bootstrap I fixed this because it was being an issue for debugging CI failures. We try to print as much information as possible, just with a slightly less verbose command description in non-verbose mode. The code is now more unified and hopefully simpler to understand. I also fixed the `format_short_cmd` logic, it was a bit weird after some recent refactors. Fixes: #145002 r? `````````@jieyouxu````````` CC `````````@Shourya742`````````

rustbot assigned jieyouxu Aug 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 8, 2025

This comment has been minimized.

Sign in to view

Improve error output when a command fails in bootstrap

d9b725a

Kobzol force-pushed the bootstrap-cmd-error branch from 96fc1e4 to d9b725a Compare August 8, 2025 13:50

Shourya742 approved these changes Aug 9, 2025

View reviewed changes

src/bootstrap/src/utils/exec.rs Show resolved Hide resolved

src/bootstrap/src/utils/exec.rs Show resolved Hide resolved

jieyouxu approved these changes Aug 9, 2025

View reviewed changes

src/bootstrap/src/utils/exec.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025

Zalathar mentioned this pull request Aug 9, 2025

Rollup of 8 pull requests #145161

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 21 pull requests #145192

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 19 pull requests #145195

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 19 pull requests #145197

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 18 pull requests #145204

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 17 pull requests #145210

Merged

bors merged commit 4e9bf08 into rust-lang:master Aug 10, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 10, 2025

Kobzol deleted the bootstrap-cmd-error branch August 10, 2025 17:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve error output when a command fails in bootstrap #145089

Improve error output when a command fails in bootstrap #145089

Uh oh!

Kobzol commented Aug 8, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Aug 8, 2025 •

edited

Loading

Uh oh!

Kobzol commented Aug 8, 2025

Uh oh!

Shourya742 left a comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu left a comment

Uh oh!

Uh oh!

jieyouxu commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Improve error output when a command fails in bootstrap #145089

Improve error output when a command fails in bootstrap #145089

Uh oh!

Conversation

Kobzol commented Aug 8, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Aug 8, 2025

Uh oh!

Shourya742 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jieyouxu commented Aug 8, 2025 •

edited

Loading