Skip to content

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Aug 5, 2025

Tracking issue - #136909

libs-api has agreed to rename these unstable functions to isolate_highest_one/isolate_lowest_one
#136909 (comment)

isolate_most_significant_one -> isolate_highest_one
isolate_least_significant_one -> isolate_lowest_one

libs-api has agreed to rename these functions to
`isolate_highest_one`/`isolate_lowest_one`
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 5, 2025
@joshtriplett
Copy link
Member

joshtriplett commented Aug 5, 2025

r=me once CI passes.

And thank you!

@jhpratt
Copy link
Member

jhpratt commented Aug 6, 2025

@bors r=joshtriplett rollup

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit eee6f80 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
bors added a commit that referenced this pull request Aug 6, 2025
Rollup of 12 pull requests

Successful merges:

 - #144552 (Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
 - #144676 (Add documentation for unstable_feature_bound)
 - #144836 (Change visibility of Args new function)
 - #144910 (Add regression tests for seemingly fixed issues)
 - #144913 ([rustdoc] Fix wrong `i` tooltip icon)
 - #144924 (compiletest: add hint for when a ui test produces no errors)
 - #144926 (Correct the use of `must_use` on btree::IterMut)
 - #144928 (Drop `rust-version` from `rustc_thread_pool`)
 - #144945 (Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls`)
 - #144954 (run-make: Allow blessing snapshot files that don't exist yet)
 - #144971 (num: Rename `isolate_most_least_significant_one` functions)
 - #144978 (Fix some doc links for intrinsics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 84dc97c into rust-lang:master Aug 6, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 6, 2025
rust-timer added a commit that referenced this pull request Aug 6, 2025
Rollup merge of #144971 - okaneco:rename_isolate_ones, r=joshtriplett

num: Rename `isolate_most_least_significant_one` functions

Tracking issue - #136909

libs-api has agreed to rename these unstable functions to `isolate_highest_one`/`isolate_lowest_one`
#136909 (comment)

`isolate_most_significant_one` -> `isolate_highest_one`
`isolate_least_significant_one` -> `isolate_lowest_one`
@okaneco okaneco deleted the rename_isolate_ones branch August 6, 2025 22:41
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 7, 2025
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#144552 (Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
 - rust-lang/rust#144676 (Add documentation for unstable_feature_bound)
 - rust-lang/rust#144836 (Change visibility of Args new function)
 - rust-lang/rust#144910 (Add regression tests for seemingly fixed issues)
 - rust-lang/rust#144913 ([rustdoc] Fix wrong `i` tooltip icon)
 - rust-lang/rust#144924 (compiletest: add hint for when a ui test produces no errors)
 - rust-lang/rust#144926 (Correct the use of `must_use` on btree::IterMut)
 - rust-lang/rust#144928 (Drop `rust-version` from `rustc_thread_pool`)
 - rust-lang/rust#144945 (Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls`)
 - rust-lang/rust#144954 (run-make: Allow blessing snapshot files that don't exist yet)
 - rust-lang/rust#144971 (num: Rename `isolate_most_least_significant_one` functions)
 - rust-lang/rust#144978 (Fix some doc links for intrinsics)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 8, 2025
…htriplett

num: Rename `isolate_most_least_significant_one` functions

Tracking issue - rust-lang#136909

libs-api has agreed to rename these unstable functions to `isolate_highest_one`/`isolate_lowest_one`
rust-lang#136909 (comment)

`isolate_most_significant_one` -> `isolate_highest_one`
`isolate_least_significant_one` -> `isolate_lowest_one`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants