Skip to content

Update rustc-perf submodule #144639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

Update rustc-perf submodule #144639

merged 4 commits into from
Jul 30, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 29, 2025

Mostly to include rust-lang/rustc-perf#2204.

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 29, 2025

@bors try @rust-timer queue

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@rust-timer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Jul 29, 2025

⌛ Trying commit 0b807fc with merge 0891bf8

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Jul 29, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 29, 2025
@lqd
Copy link
Member

lqd commented Jul 29, 2025

r? lqd r=me with green/neutral perf :3

@rustbot rustbot assigned lqd and unassigned Mark-Simulacrum Jul 29, 2025
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

There are changes to the tidy tool.

cc @jieyouxu

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rust-bors
Copy link

rust-bors bot commented Jul 29, 2025

☀️ Try build successful (CI)
Build commit: 0891bf8 (0891bf8d28a77573eaa3ab46ecc65bdb8b00dbc8, parent: 7278554d82fa474a4e8b5c67afb009e11e41a841)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0891bf8): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.8%, secondary 19.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.8% [3.8%, 3.8%] 1
Regressions ❌
(secondary)
19.5% [18.2%, 20.7%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.8% [3.8%, 3.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.638s -> 468.356s (0.15%)
Artifact size: 376.88 MiB -> 376.85 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 29, 2025
@lqd
Copy link
Member

lqd commented Jul 29, 2025

@Kobzol how stable are cycles and wall times on the new server? This no op change has weird metrics there :/

@Kobzol
Copy link
Member Author

Kobzol commented Jul 29, 2025

https://perf.rust-lang.org/index.html?kind=raw&stat=cycles%3Au cycles are relatively stable (compare e.g. with wall-time, which is much more noisy). I don't know what caused this blip, but I haven't seen anything like it recently. Looking at the ctfe-stress results it looks like that benchmark is particularly noisy on cycles though, not sure why.

@lqd
Copy link
Member

lqd commented Jul 29, 2025

Strange yes. Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 29, 2025

📌 Commit b60026a has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2025
bors added a commit that referenced this pull request Jul 29, 2025
Rollup of 8 pull requests

Successful merges:

 - #144034 (tests: Test line number in debuginfo for diverging function calls)
 - #144510 (Fix Ord, Eq and Hash implementation of panic::Location)
 - #144583 (Enable T-compiler backport nomination)
 - #144586 (Update wasi-sdk to 27.0 in CI)
 - #144605 (Resolve: cachify `ExternPreludeEntry.binding` through a `Cell`)
 - #144632 (Update some tests for LLVM 21)
 - #144639 (Update rustc-perf submodule)
 - #144640 (Add support for the m68k architecture in 'object_architecture')

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 322686d into rust-lang:master Jul 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 30, 2025
rust-timer added a commit that referenced this pull request Jul 30, 2025
Rollup merge of #144639 - Kobzol:x-perf-tui, r=lqd

Update rustc-perf submodule

Mostly to include rust-lang/rustc-perf#2204.
@Kobzol Kobzol deleted the x-perf-tui branch July 30, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants