Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #144548

Oneirical · 2025-07-27T21:21:20Z

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

Refer to the previously written tests/ui/SUMMARY.md
Find an appropriate category for the test, using the original issue thread and the test contents.
Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

rustbot · 2025-07-27T21:21:25Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-07-27T21:56:27Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

jieyouxu · 2025-07-28T16:46:44Z

For future PRs like this where you have both moves and edits, can you make sure to split the changes into two commits, with commit 1 being move-only, and commit 2 being edits? This is intended to make it easier to navigate git history. I wouldn't worry so much about PRs you already have opened.

jieyouxu

Thanks, a few issues

tests/ui/array-slice-vec/collection-type-copy-behavior-12909.rs

tests/ui/borrowck/borrow-checker-lifetime-error-464711.rs

tests/ui/functions-closures/autoderef-vec-box-fn-36786.rs

tests/ui/macros/macro-expansion-bypasses-derive-stability-32655.rs

tests/ui/result/env-var-handling-36023.rs

tests/ui/trait-bounds/incorrect-self-type-in-trait-impl-48276.rs

tests/ui/trait-bounds/parenthesized-type-parameters-error-329952.rs

tests/ui/trait-bounds/parenthesized-type-parameters-error-329952.stderr

jieyouxu · 2025-07-30T06:32:36Z

tidy error: Stray file with UI testing output: "/checkout/tests/ui/trait-bounds/incorrect-self-type-in-trait-impl-48276.stderr"

jieyouxu

Thanks, can you squash after removing stray stderr?

petrochenkov · 2025-07-30T10:53:37Z

@Oneirical
Do you use https://github.com/petrochenkov/classifui for doing this work?
The tool was discussed a lot in the previous issue (#73494), but #133895 removed any mentions of it for some reason.
It really helps to 1) select the test that can be moved with high confidence and 2) keep contents of the subdirectories self-consistent.

Oneirical · 2025-08-01T04:23:36Z

@Oneirical Do you use https://github.com/petrochenkov/classifui for doing this work? The tool was discussed a lot in the previous issue (#73494), but #133895 removed any mentions of it for some reason. It really helps to 1) select the test that can be moved with high confidence and 2) keep contents of the subdirectories self-consistent.

I have never heard of such a tool! In fact, we were talking about making something like this in the Google Summer of Code chat, but it never solidified into anything. I'll definitely be looking into this!!

petrochenkov · 2025-08-01T07:31:15Z

@Oneirical Do you use https://github.com/petrochenkov/classifui for doing this work? The tool was discussed a lot in the previous issue (#73494), but #133895 removed any mentions of it for some reason. It really helps to 1) select the test that can be moved with high confidence and 2) keep contents of the subdirectories self-consistent.

I have never heard of such a tool! In fact, we were talking about making something like this in the Google Summer of Code chat, but it never solidified into anything. I'll definitely be looking into this!!

We already moved hundreds (probably >1000) tests using it as a part of #73494, it's quite strange that you haven't seen it and @jieyouxu didn't mention it.

jieyouxu · 2025-08-01T08:29:45Z

We already moved hundreds (probably >1000) tests using it as a part of #73494, it's quite strange that you haven't seen it and @jieyouxu didn't mention it.

Uh sorry, I thought I mentioned it, but I didn't

Oneirical · 2025-08-02T23:42:28Z

@rustbot review

jieyouxu

Thanks

jieyouxu · 2025-08-04T08:26:29Z

@bors r+ rollup

bors · 2025-08-04T08:26:31Z

📌 Commit 807d340 has been approved by jieyouxu

It is now in the queue for this repository.

…=jieyouxu Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` rust-lang#143902 divided into smaller, easier to review chunks. Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`

Rollup of 18 pull requests Successful merges: - #144467 (rustdoc template font links only emit `crossorigin` when needed) - #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144596 (libtest: print the type of test being run) - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - #144776 (`Printer` cleanups) - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - #144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - #144867 (Use `as_array` in PartialEq for arrays) - #144872 (Document Poisoning in `LazyCell` and `LazyLock`) - #144877 (coverage: Various small cleanups) - #144887 (`rust-analyzer` subtree update) - #144890 (Add `InterpCx::project_fields`) - #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - #144905 (rustc-dev-guide subtree update) - #144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #144467 (rustdoc template font links only emit `crossorigin` when needed) - #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - #144776 (`Printer` cleanups) - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - #144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - #144867 (Use `as_array` in PartialEq for arrays) - #144872 (Document Poisoning in `LazyCell` and `LazyLock`) - #144877 (coverage: Various small cleanups) - #144887 (`rust-analyzer` subtree update) - #144890 (Add `InterpCx::project_fields`) - #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - #144905 (rustc-dev-guide subtree update) - #144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144548 - Oneirical:uncountable-integer-2, r=jieyouxu Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #143902 divided into smaller, easier to review chunks. Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that ``@Kivooeo`` was using. r? ``@jieyouxu``

Rollup of 17 pull requests Successful merges: - rust-lang/rust#144467 (rustdoc template font links only emit `crossorigin` when needed) - rust-lang/rust#144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang/rust#144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - rust-lang/rust#144776 (`Printer` cleanups) - rust-lang/rust#144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - rust-lang/rust#144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - rust-lang/rust#144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - rust-lang/rust#144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - rust-lang/rust#144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - rust-lang/rust#144867 (Use `as_array` in PartialEq for arrays) - rust-lang/rust#144872 (Document Poisoning in `LazyCell` and `LazyLock`) - rust-lang/rust#144877 (coverage: Various small cleanups) - rust-lang/rust#144887 (`rust-analyzer` subtree update) - rust-lang/rust#144890 (Add `InterpCx::project_fields`) - rust-lang/rust#144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - rust-lang/rust#144905 (rustc-dev-guide subtree update) - rust-lang/rust#144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jul 27, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2025

This comment has been minimized.

Sign in to view

Oneirical changed the title ~~Rehome 30 tests/ui/issues/ tests to other subdirectories under tests/ui/~~ Rehome 21 tests/ui/issues/ tests to other subdirectories under tests/ui/ Jul 27, 2025

Oneirical force-pushed the uncountable-integer-2 branch from 6b978c5 to 6b48664 Compare July 27, 2025 21:56

This comment has been minimized.

Sign in to view

Oneirical force-pushed the uncountable-integer-2 branch from 6b48664 to a9ed9a4 Compare July 27, 2025 22:44

jieyouxu requested changes Jul 28, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025

This comment has been minimized.

Sign in to view

jieyouxu approved these changes Jul 30, 2025

View reviewed changes

Oneirical force-pushed the uncountable-integer-2 branch from dedb801 to ee8e809 Compare August 1, 2025 04:22

This comment has been minimized.

Sign in to view

Rehome tests/ui/issues/ tests [2/?]

807d340

Oneirical force-pushed the uncountable-integer-2 branch from ee8e809 to 807d340 Compare August 2, 2025 19:29

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2025

jieyouxu approved these changes Aug 4, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025

samueltardieu mentioned this pull request Aug 4, 2025

Rollup of 18 pull requests #144929

Closed

samueltardieu mentioned this pull request Aug 5, 2025

Rollup of 17 pull requests #144934

Merged

bors merged commit 58b00b0 into rust-lang:master Aug 5, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 5, 2025

Kobzol mentioned this pull request Aug 5, 2025

Rollup of 11 pull requests #144950

Closed

samueltardieu mentioned this pull request Aug 5, 2025

Rollup of 16 pull requests #144951

Closed

Rehome 21 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144548

Rehome 21 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144548

Uh oh!

Conversation

Oneirical commented Jul 27, 2025

Uh oh!

rustbot commented Jul 27, 2025

Uh oh!

This comment has been minimized.

rustbot commented Jul 27, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 28, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 30, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented Jul 30, 2025

Uh oh!

Oneirical commented Aug 1, 2025

Uh oh!

This comment has been minimized.

petrochenkov commented Aug 1, 2025

Uh oh!

jieyouxu commented Aug 1, 2025

Uh oh!

Oneirical commented Aug 2, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 4, 2025

Uh oh!

bors commented Aug 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #144548

Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #144548