Change for desugaring & make refutable pattern errors more precise
#14444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…let`s or `for`s.
Member
|
Legit Travis failure |
messages when the pattern is refutable. This means the compiler points directly to the pattern and said that the problem is the pattern being refutable (rather than just saying that some value isn't covered in the `match` as it did previously). Fixes rust-lang#14390.
The compiler now points exactly which part(s) of a pattern are refutable, rather than just highlighting the whole pattern.
Contributor
Author
|
Passes travis now. |
bors
added a commit
that referenced
this pull request
May 27, 2014
Change `for` desugaring & make refutable pattern errors more precise This changes for to desugar to the `let`-based pattern match as described in #14390, and adjusts the compiler to use this information for error messages that even mention that it's in a `for` loop. Also, it makes the compiler record the exact positions of refutable parts of a pattern, to point to exactly them in error messages.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…ng-properly, r=Veykril
Missing runnable env on debug target
Fix bug in Rust Analyzer VSCode where runnable debugging did not pass
environment variable from configuration to child process of Cargo on binary build stage
There is a missing env passing along to `cargo` in debug target which give an in-consistent result from debug and run target
For example
```json
{
"rust-analyzer.runnableEnv": {
"OUT_DIR": "/test/path2"
}
}
```
## run
## debug
compiling binary is failed. Missing env
## debug (after fix)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 22, 2025
) Closes rust-lang#9191 Closes rust-lang#14444 Closes rust-lang#8055 Adds a new helper to partly check for side effects by recursively checking if the iterator type contains closures with mutable captures. changelog: [`double_ended_iterator_last`] fix FP when iter has side effects changelog: [`needless_collect`] fix lint not consider side effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
fordesugaring & make refutable pattern errors more preciseThis changes for to desugar to the
let-based pattern match as described in #14390, and adjusts the compiler to use this information for error messages that even mention that it's in aforloop.Also, it makes the compiler record the exact positions of refutable parts of a pattern, to point to exactly them in error messages.