Skip to content

Conversation

@thaliaarchi
Copy link
Contributor

@thaliaarchi thaliaarchi commented Jul 17, 2025

The corresponding new_uninit and new_uninit_slice functions were stabilized in #129401, but the zeroed counterparts were left for later out of a desire to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: #129396

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 17, 2025
@rust-log-analyzer

This comment has been minimized.

@thaliaarchi thaliaarchi force-pushed the stabilize-new-zeroed branch 2 times, most recently from 36a935b to a84ecd9 Compare July 17, 2025 23:07
@thaliaarchi
Copy link
Contributor Author

thaliaarchi commented Jul 17, 2025

@jieyouxu Are the bootstrap gates for rustc_index correct with the redesigned bootstrap sequence? It needs to be compilable in four ways: with feature = "nightly" by stage0, stage1, or from crates.io, or without feature = "nightly" from crates.io.

@rust-log-analyzer

This comment has been minimized.

@thaliaarchi thaliaarchi force-pushed the stabilize-new-zeroed branch 2 times, most recently from f9df154 to 081ce42 Compare July 17, 2025 23:37
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025
@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-team DEPRECATED: Use the team-based variants `S-waiting-on-t-lang`, `S-waiting-on-t-compiler`, ... needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 19, 2025
@thaliaarchi thaliaarchi force-pushed the stabilize-new-zeroed branch from 081ce42 to 0c18553 Compare July 19, 2025 23:30
@rust-log-analyzer

This comment has been minimized.

@thaliaarchi thaliaarchi force-pushed the stabilize-new-zeroed branch from 0c18553 to 6d1c12a Compare July 19, 2025 23:37
@thaliaarchi

This comment was marked as resolved.

@rust-log-analyzer

This comment has been minimized.

@thaliaarchi thaliaarchi force-pushed the stabilize-new-zeroed branch from 6d1c12a to c82db9b Compare July 19, 2025 23:53
@thaliaarchi thaliaarchi force-pushed the stabilize-new-zeroed branch from c82db9b to 175afd7 Compare July 20, 2025 03:25
@Amanieu
Copy link
Member

Amanieu commented Jul 22, 2025

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jul 22, 2025

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 20, 2025

📌 Commit 175afd7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2025
bors added a commit that referenced this pull request Sep 20, 2025
…lacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: #129396
@bors
Copy link
Collaborator

bors commented Sep 20, 2025

⌛ Testing commit 175afd7 with merge e9c050c...

tgross35 added a commit to tgross35/rust that referenced this pull request Sep 20, 2025
…r=Mark-Simulacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: rust-lang#129396
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 20, 2025
…r=Mark-Simulacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: rust-lang#129396
@tgross35
Copy link
Contributor

@bors retry rolled up

bors added a commit that referenced this pull request Sep 20, 2025
Rollup of 6 pull requests

Successful merges:

 - #140983 (Improve doc of some methods that take ranges)
 - #144091 (Stabilize `new_zeroed_alloc`)
 - #145664 (Stabilize `std::panic::Location::file_as_c_str`)
 - #146744 (Deref related cleanups in ref_prop)
 - #146793 (naked_asm: emit a label starting with `func_end`)
 - #146822 (Fix old typo in lang_start_internal comment)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 21, 2025
…lacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: #129396
@bors
Copy link
Collaborator

bors commented Sep 21, 2025

⌛ Testing commit 175afd7 with merge 95cd055...

@tgross35
Copy link
Contributor

@bors retry same thing

bors added a commit that referenced this pull request Sep 21, 2025
Rollup of 6 pull requests

Successful merges:

 - #140983 (Improve doc of some methods that take ranges)
 - #144091 (Stabilize `new_zeroed_alloc`)
 - #145664 (Stabilize `std::panic::Location::file_as_c_str`)
 - #146744 (Deref related cleanups in ref_prop)
 - #146793 (naked_asm: emit a label starting with `func_end`)
 - #146822 (Fix old typo in lang_start_internal comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Sep 21, 2025

⌛ Testing commit 175afd7 with merge 8380f92...

bors added a commit that referenced this pull request Sep 21, 2025
…lacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: #129396
@Zalathar
Copy link
Member

Yielding to rollup again. Sorry for the noise; CI has been flaking out.

@bors retry

bors added a commit that referenced this pull request Sep 21, 2025
Rollup of 8 pull requests

Successful merges:

 - #140983 (Improve doc of some methods that take ranges)
 - #144091 (Stabilize `new_zeroed_alloc`)
 - #145664 (Stabilize `std::panic::Location::file_as_c_str`)
 - #146551 (fix issue with `cmse-nonsecure-entry` ABI being both async and c-variadic)
 - #146744 (Deref related cleanups in ref_prop)
 - #146793 (naked_asm: emit a label starting with `func_end`)
 - #146820 (Add unstable attribute to BTreeMap-related allocator generics)
 - #146822 (Fix old typo in lang_start_internal comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a5819d into rust-lang:master Sep 21, 2025
11 of 12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 21, 2025
@bors
Copy link
Collaborator

bors commented Sep 21, 2025

⌛ Testing commit 175afd7 with merge dfa2223...

rust-timer added a commit that referenced this pull request Sep 21, 2025
Rollup merge of #144091 - thaliaarchi:stabilize-new-zeroed, r=Mark-Simulacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: #129396
@thaliaarchi thaliaarchi deleted the stabilize-new-zeroed branch September 21, 2025 21:48
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
…r=Mark-Simulacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: rust-lang#129396
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#140983 (Improve doc of some methods that take ranges)
 - rust-lang#144091 (Stabilize `new_zeroed_alloc`)
 - rust-lang#145664 (Stabilize `std::panic::Location::file_as_c_str`)
 - rust-lang#146551 (fix issue with `cmse-nonsecure-entry` ABI being both async and c-variadic)
 - rust-lang#146744 (Deref related cleanups in ref_prop)
 - rust-lang#146793 (naked_asm: emit a label starting with `func_end`)
 - rust-lang#146820 (Add unstable attribute to BTreeMap-related allocator generics)
 - rust-lang#146822 (Fix old typo in lang_start_internal comment)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…r=Mark-Simulacrum

Stabilize `new_zeroed_alloc`

The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: rust-lang#129396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants