Skip to content

Port #[automatically_derived] to the new attribute parsing infrastructure #143779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Port #[automatically_derived] to the new attribute parsing infrastructure #143779

wants to merge 3 commits into from
+92 −50

Conversation

JonathanBrouwer
Copy link
Contributor

Ports #[automatically_derived] to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk
cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in match checking

cc @Nadrieril

JonathanBrouwer
JonathanBrouwer commented Jul 11, 2025
View reviewed changes
compiler/rustc_hir/src/hir.rs
@@ -1304,6 +1304,7 @@ impl AttributeExt for Attribute {
Attribute::Parsed(AttributeKind::DocComment { span, .. }) => *span,
Attribute::Parsed(AttributeKind::MayDangle(span)) => *span,
Attribute::Parsed(AttributeKind::Ignore { span, .. }) => *span,
Attribute::Parsed(AttributeKind::AutomaticallyDerived(span)) => *span,
Copy link
Contributor Author

@JonathanBrouwer JonathanBrouwer Jul 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is needed to fix #143780 for automatically_derived. automatically_derived is part of a test case so this is necessary to add now. @jdonszelmann and I are discussing a general solution to this problem.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer JonathanBrouwer force-pushed the automatically_derived_parser branch from 8ffd1bf to 499af0e Compare July 11, 2025 11:32
@Kobzol
Copy link
Member

Kobzol commented Jul 11, 2025

There are lots of these attributes produced by built-in derives, let's do a perf. run once this is ready.

@bors
Copy link
Collaborator

bors commented Jul 12, 2025

☔ The latest upstream changes (presumably #143810) made this pull request unmergeable. Please resolve the merge conflicts.

@JonathanBrouwer
Port #[automatically_derived] to the new attribute parsing infrastr…
ef82007 
…ucture

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
@JonathanBrouwer
Fix clippy & rustdoc-json
a1cfca3 
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
@JonathanBrouwer
Update uitest stderrs
68066b9 
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
@JonathanBrouwer JonathanBrouwer force-pushed the automatically_derived_parser branch from 499af0e to 68066b9 Compare July 12, 2025 15:51
@jdonszelmann jdonszelmann mentioned this pull request Jul 12, 2025
Open
9 tasks
@jdonszelmann
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 12, 2025
bors added a commit that referenced this pull request Jul 12, 2025
@bors
Auto merge of #143779 - JonathanBrouwer:automatically_derived_parser,…
bc14627 
… r=<try>

Port `#[automatically_derived]` to the new attribute parsing infrastructure

Ports `#[automatically_derived]` to the new attribute parsing infrastructure for #131229 (comment)

r? `@oli-obk`
cc `@jdonszelmann`
@bors
Copy link
Collaborator

bors commented Jul 12, 2025

⌛ Trying commit 68066b9 with merge bc14627...

@bors
Copy link
Collaborator

bors commented Jul 12, 2025

☀️ Try build successful - checks-actions
Build commit: bc14627 (bc146279bdc1ca321ed03225099bba4299bcd965)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bc14627): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.1%] 1
Improvements ✅
(secondary)		 -0.2% [-0.3%, -0.2%] 8
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 1

Max RSS (memory usage)

Results (primary -1.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 -4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Cycles

Results (primary 1.4%, secondary 5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.6% [2.3%, 2.8%] 3
Regressions ❌
(secondary)		 5.8% [2.4%, 9.2%] 2
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.4% [-2.2%, 2.8%] 4

Binary size

Results (primary -0.1%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.3%, -0.0%] 71
Improvements ✅
(secondary)		 -0.4% [-1.8%, -0.0%] 31
All ❌✅ (primary) -0.1% [-0.3%, -0.0%] 71

Bootstrap: 464.174s -> 466.768s (0.56%)
Artifact size: 374.70 MiB -> 374.67 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 12, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 13, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

📌 Commit 68066b9 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025
@jdonszelmann
Copy link
Contributor

damn, no regressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JonathanBrouwer @rustbot @rust-log-analyzer @Kobzol @bors @jdonszelmann @rust-timer @oli-obk