Skip to content

Mention more APIs in ParseIntError docs #143611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

Mention more APIs in ParseIntError docs #143611

merged 1 commit into from
Jul 12, 2025
+5 −2

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jul 7, 2025 •
edited
Loading

Fixes #143602

r? @lolbinarycat

@rustbot label +A-docs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jul 7, 2025
lolbinarycat
lolbinarycat reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@lolbinarycat lolbinarycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but I don't have reviewer permissions, so..

r? t-libs

library/core/src/num/error.rs Outdated
@@ -45,8 +45,11 @@ impl From<!> for TryFromIntError {

/// An error which can be returned when parsing an integer.
///
/// This error is used as the error type for the `from_str_radix()` functions
/// on the primitive integer types, such as [`i8::from_str_radix`].
/// For example, this error is used in `from_str_radix()` functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// For example, this error is used in `from_str_radix()` functions
/// For example, this error is returned by the `from_str_radix()` functions

nit

@rustbot rustbot assigned thomcc and unassigned lolbinarycat Jul 7, 2025
@ChrisDenton
Copy link
Member

Just as a general note, you should not usually r? an individual unless they explicitly asked for it (or you know they're the only person able to review). Even if someone with r+ permissions creates an issue, they may not have the bandwidth to review and someone else might be able and willing to. You can still @ them if you think it's important that they're aware.

lolbinarycat
lolbinarycat reviewed Jul 7, 2025
View reviewed changes
library/core/src/num/error.rs Outdated
/// on the primitive integer types, such as [`i8::from_str_radix`].
/// For example, this error is returned by the `from_str_radix()` functions
/// on the primitive integer types (such as [`i8::from_str_radix`])
/// and as the error type in their [`FromStr`] implementations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// and as the error type in their [`FromStr`] implementations.
/// and is used as the error type in their [`FromStr`] implementations.

Just realized my change to the first half means the second half also needs to be rewritten in order to still make sense.

@tgross35
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 11, 2025

📌 Commit ae5cb5f has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
@tgross35 tgross35 assigned tgross35 and unassigned thomcc Jul 11, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 11, 2025
Merged
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143766 - matthiaskrgr:rollup-0x7t69s, r=matthiaskrgr
256cb72 
Rollup of 8 pull requests

Successful merges:

 - #142391 (rust: library: Add `setsid` method to `CommandExt` trait)
 - #143302 (`tests/ui`: A New Order [27/N])
 - #143303 (`tests/ui`: A New Order [28/28] FINAL PART)
 - #143568 (std: sys: net: uefi: tcp4: Add timeout support)
 - #143611 (Mention more APIs in `ParseIntError` docs)
 - #143661 (chore: Improve how the other suggestions message gets rendered)
 - #143708 (fix: Include frontmatter in -Zunpretty output )
 - #143718 (Make UB transmutes really UB in LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143766 - matthiaskrgr:rollup-0x7t69s, r=matthiaskrgr
6c42131 
Rollup of 8 pull requests

Successful merges:

 - #142391 (rust: library: Add `setsid` method to `CommandExt` trait)
 - #143302 (`tests/ui`: A New Order [27/N])
 - #143303 (`tests/ui`: A New Order [28/28] FINAL PART)
 - #143568 (std: sys: net: uefi: tcp4: Add timeout support)
 - #143611 (Mention more APIs in `ParseIntError` docs)
 - #143661 (chore: Improve how the other suggestions message gets rendered)
 - #143708 (fix: Include frontmatter in -Zunpretty output )
 - #143718 (Make UB transmutes really UB in LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143766 - matthiaskrgr:rollup-0x7t69s, r=<try>
ae2eccf 
Rollup of 8 pull requests

Successful merges:

 - #142391 (rust: library: Add `setsid` method to `CommandExt` trait)
 - #143302 (`tests/ui`: A New Order [27/N])
 - #143303 (`tests/ui`: A New Order [28/28] FINAL PART)
 - #143568 (std: sys: net: uefi: tcp4: Add timeout support)
 - #143611 (Mention more APIs in `ParseIntError` docs)
 - #143661 (chore: Improve how the other suggestions message gets rendered)
 - #143708 (fix: Include frontmatter in -Zunpretty output )
 - #143718 (Make UB transmutes really UB in LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: i686-gnu-nopt-1
try-job: test-various
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143766 - matthiaskrgr:rollup-0x7t69s, r=matthiaskrgr
79464cc 
Rollup of 8 pull requests

Successful merges:

 - #142391 (rust: library: Add `setsid` method to `CommandExt` trait)
 - #143302 (`tests/ui`: A New Order [27/N])
 - #143303 (`tests/ui`: A New Order [28/28] FINAL PART)
 - #143568 (std: sys: net: uefi: tcp4: Add timeout support)
 - #143611 (Mention more APIs in `ParseIntError` docs)
 - #143661 (chore: Improve how the other suggestions message gets rendered)
 - #143708 (fix: Include frontmatter in -Zunpretty output )
 - #143718 (Make UB transmutes really UB in LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: i686-gnu-nopt-1
try-job: test-various
bors added a commit that referenced this pull request Jul 12, 2025
@bors
Auto merge of #143766 - matthiaskrgr:rollup-0x7t69s, r=matthiaskrgr
2f9c9ce 
Rollup of 8 pull requests

Successful merges:

 - #142391 (rust: library: Add `setsid` method to `CommandExt` trait)
 - #143302 (`tests/ui`: A New Order [27/N])
 - #143303 (`tests/ui`: A New Order [28/28] FINAL PART)
 - #143568 (std: sys: net: uefi: tcp4: Add timeout support)
 - #143611 (Mention more APIs in `ParseIntError` docs)
 - #143661 (chore: Improve how the other suggestions message gets rendered)
 - #143708 (fix: Include frontmatter in -Zunpretty output )
 - #143718 (Make UB transmutes really UB in LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: i686-gnu-nopt-1
try-job: test-various
@bors bors merged commit 2ffaa1e into rust-lang:master Jul 12, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 12, 2025
rust-timer added a commit that referenced this pull request Jul 12, 2025
@rust-timer
Unrolled build for #143611
04765b9 
Rollup merge of #143611 - GrigorenkoPV:ParseIntError, r=tgross35

Mention more APIs in `ParseIntError` docs

Fixes #143602

r? `@lolbinarycat`

`@rustbot` label +A-docs
@GrigorenkoPV GrigorenkoPV deleted the ParseIntError branch July 12, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolbinarycat lolbinarycat lolbinarycat approved these changes

Assignees

@tgross35 tgross35

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.

ParseIntError docs should mention other integer parsing functions
7 participants
@GrigorenkoPV @ChrisDenton @tgross35 @bors @lolbinarycat @thomcc @rustbot