Skip to content

configure.py: Write last key in each section #143606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/bootstrap/configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -739,19 +739,29 @@ def configure_file(sections, top_level_keys, targets, config):


def write_uncommented(target, f):
"""Writes each block in 'target' that is not composed entirely of comments to 'f'.

A block is a sequence of non-empty lines separated by empty lines.
"""
block = []
is_comment = True

def flush(last):
# If the block is entirely made of comments, ignore it
entire_block_comments = all(ln.startswith("#") or ln == "" for ln in block)
if not entire_block_comments and len(block) > 0:
for line in block:
f.write(line + "\n")
# Required to output a newline before the start of a new section
if last:
f.write("\n")
block.clear()

for line in target:
block.append(line)
if len(line) == 0:
if not is_comment:
for ln in block:
f.write(ln + "\n")
block = []
is_comment = True
continue
is_comment = is_comment and line.startswith("#")
flush(last=False)

flush(last=True)
return f


Expand Down
Loading