Skip to content

[perf] Consider param-env for fast path #143309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

compiler-errors
Copy link
Member

No description provided.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 2, 2025
@compiler-errors
Copy link
Member Author

@bors2 try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors
Copy link

rust-bors bot commented Jul 2, 2025

⌛ Trying commit 089656e with merge 7c68135

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 2, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 2, 2025
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [ui] tests/ui/where-clauses/ignore-err-clauses.rs stdout ----

error: 1 unexpected diagnostics reported, 1 expected diagnostics not reported
--- reported in JSON output but not expected in test file ---
tests/ui/where-clauses/ignore-err-clauses.rs:10:9: ERROR: use of moved value: `x` [E0382]
---
--- expected in test file but not reported in JSON output ---
tests/ui/where-clauses/ignore-err-clauses.rs:3:1: ERROR: type annotations needed
  reported with kind NOTE with message move occurs because `x` has type `T`, which does not implement the `Copy` trait
  reported with kind HELP with message if `T` implemented `Clone`, you could clone the value
  reported with kind NOTE with message consider constraining this type parameter with `Clone`
---

thread '[ui] tests/ui/where-clauses/ignore-err-clauses.rs' panicked at src/tools/compiletest/src/runtest.rs:884:13:
errors differ from expected
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/where-clauses/ignore-err-clauses.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/where-clauses/ignore-err-clauses" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"



failures:
    [ui] tests/ui/where-clauses/ignore-err-clauses.rs

@rust-bors
Copy link

rust-bors bot commented Jul 2, 2025

☀️ Try build successful (CI)
Build commit: 7c68135 (7c68135aa7729b5e1a168883c992b097f120c51a, parent: 085c24790e591948f788fd294ca3f9858313741c)

@rust-timer
Copy link
Collaborator

Queued 7c68135 with parent 085c247, future comparison URL.
There are currently 5 preceding artifacts in the queue.
It will probably take at least ~5.2 hours until the benchmark run finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants