Fast path nitpicks #143307
Open
Fast path nitpicks #143307
+31
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
compiler-errors
commented
Jul 2, 2025
| @@ -34,13 +34,6 @@ pub(crate) fn codegen_select_candidate<'tcx>( | |||
| let (infcx, param_env) = tcx.infer_ctxt().ignoring_regions().build_with_typing_env(typing_env); | |||
| let mut selcx = SelectionContext::new(&infcx); | |||
|
|
|||
| if sizedness_fast_path(tcx, trait_ref.upcast(tcx)) { | |||
There was a problem hiding this comment.
This function shouldn't ever be reached -- we never do Instance::resolve on Sized.
|
@bors2 try @rust-timer queue r? lcnr perhaps |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rust-bors bot
added a commit
that referenced
this pull request
Jul 2, 2025
Fast path nitpicks Miscellaneous commits that I didn't really want to fold into anything else. Fixes one theoretical bug with the fast path not considering polarity for `T: !Sized` bounds.
rustbot
added
the
S-waiting-on-perf
|
Queued 227ec3b with parent 71e4c00, future comparison URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous commits that I didn't really want to fold into anything else.
Fixes one theoretical bug with the fast path not considering polarity for
T: !Sizedbounds.